[iOS] Fixed KeepLastItemInView for CV1 and added support for KeepLastItemInView for CV2 #28720
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui" | ||
| xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" | ||
| x:Class="Maui.Controls.Sample.Issues.Issue28720"> | ||
| <Grid RowDefinitions="Auto,100,100,100"> | ||
| <Button Text="Add Item" | ||
| Command="{Binding AddItemCommand}" | ||
| AutomationId="AddItemButton" | ||
| HorizontalOptions="Center" | ||
| VerticalOptions="Center"/> | ||
| <CollectionView | ||
| ItemsUpdatingScrollMode="KeepLastItemInView" | ||
| ItemsSource="{Binding Items}" | ||
| Grid.Row="1"> | ||
| <CollectionView.ItemsLayout> | ||
| <LinearItemsLayout Orientation="Horizontal"/> | ||
| </CollectionView.ItemsLayout> | ||
| <CollectionView.ItemTemplate> | ||
| <DataTemplate> | ||
| <Label Text="{Binding . ,StringFormat='{0}cv1'}"/> | ||
| </DataTemplate> | ||
| </CollectionView.ItemTemplate> | ||
| </CollectionView> | ||
| <CollectionView | ||
| ItemsUpdatingScrollMode="KeepLastItemInView" | ||
| FlowDirection="RightToLeft" | ||
| ItemsSource="{Binding Items}" | ||
| Grid.Row="2"> | ||
| <CollectionView.ItemsLayout> | ||
| <LinearItemsLayout Orientation="Horizontal"/> | ||
| </CollectionView.ItemsLayout> | ||
| <CollectionView.ItemTemplate> | ||
| <DataTemplate> | ||
| <Label Text="{Binding . ,StringFormat='{0}cv2'}"/> | ||
| </DataTemplate> | ||
| </CollectionView.ItemTemplate> | ||
| </CollectionView> | ||
| <CollectionView | ||
| ItemsUpdatingScrollMode="KeepLastItemInView" | ||
| ItemsSource="{Binding Items}" | ||
| Grid.Row="3"> | ||
| <CollectionView.ItemTemplate> | ||
| <DataTemplate> | ||
| <Label Text="{Binding . ,StringFormat='{0}cv3'}"/> | ||
| </DataTemplate> | ||
| </CollectionView.ItemTemplate> | ||
| </CollectionView> | ||
| </Grid> | ||
| </ContentPage> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| using System.Collections.ObjectModel; | ||
|
|
||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 28720, "Support for KeepLastItemInView for CV2", PlatformAffected.iOS)] | ||
| public partial class Issue28720 : ContentPage | ||
| { | ||
| private ObservableCollection<string> _items; | ||
| public ObservableCollection<string> Items | ||
| { | ||
| get => _items; | ||
| set | ||
| { | ||
| if (_items != value) | ||
| { | ||
| _items = value; | ||
| OnPropertyChanged(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public Command AddItemCommand => new(() => | ||
| { | ||
| Items.Add($"Item{_items.Count}"); | ||
| }); | ||
|
|
||
| public Issue28720() | ||
| { | ||
| InitializeComponent(); | ||
| Items = [.. Enumerable.Range(0, 20).Select(x => $"Item{x}")]; | ||
| BindingContext = this; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
| public class Issue28720 : _IssuesUITest | ||
| { | ||
| public Issue28720(TestDevice testDevice) : base(testDevice) | ||
| { | ||
| } | ||
|
|
||
| public override string Issue => "Support for KeepLastItemInView for CV2"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.CollectionView)] | ||
| public void KeepLastItemInViewShouldWork() | ||
| { | ||
| App.WaitForElement("AddItemButton"); | ||
| App.Click("AddItemButton"); | ||
| App.WaitForElement("Item20cv1"); | ||
| App.WaitForElement("Item20cv2"); | ||
| App.WaitForElement("Item20cv3"); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding FinalizeCollectionViewUpdates to scroll to the last item is a significant behavior change; please ensure tests verify the accuracy of this scrolling behavior.
Copilot uses AI. Check for mistakes.