Fixed Test case failure in PR 28486 #28780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@Vignesh-SF3580! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
github-actions
bot
force-pushed
the
inflight/current
branch
from
c3d7dd2 to
5b2afee
Compare
|
/rebase |
PureWeen
force-pushed
the
fix-TestFailure
branch
from
19f88c6 to
687d016
Compare
|
/azp run MAUI-UITests-public |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Vignesh-SF3580
requested review from
mattleibow and
rmarinho
and removed request for
a team
jsuarezruiz
reviewed
Apr 4, 2025
...ntrols/tests/TestCases.Mac.Tests/snapshots/mac/EntryClearButtonColorShouldMatchTextColor.png
Show resolved
Hide resolved
jsuarezruiz
approved these changes
Apr 7, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 8, 2025
* Resolved the ScrollView TestFailures in Inflight. * updated ReorderBetweenGroupsShouldNotOccurWhenCanMixGroupsIsFalse ios image * Updated EntryClearButtonColorShouldMatchTextColor mac image
PureWeen
pushed a commit
that referenced
this pull request
Apr 8, 2025
* Resolved the ScrollView TestFailures in Inflight. * updated ReorderBetweenGroupsShouldNotOccurWhenCanMixGroupsIsFalse ios image * Updated EntryClearButtonColorShouldMatchTextColor mac image # Conflicts: # src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/ReorderBetweenGroupsShouldNotOccurWhenCanMixGroupsIsFalse.png # src/Core/src/Handlers/ScrollView/ScrollViewHandler.iOS.cs
bhavanesh2001
pushed a commit
to bhavanesh2001/maui
that referenced
this pull request
Apr 11, 2025
* Resolved the ScrollView TestFailures in Inflight. * updated ReorderBetweenGroupsShouldNotOccurWhenCanMixGroupsIsFalse ios image * Updated EntryClearButtonColorShouldMatchTextColor mac image
PureWeen
pushed a commit
that referenced
this pull request
Apr 11, 2025
* Resolved the ScrollView TestFailures in Inflight. * updated ReorderBetweenGroupsShouldNotOccurWhenCanMixGroupsIsFalse ios image * Updated EntryClearButtonColorShouldMatchTextColor mac image
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2025
* Resolved the ScrollView TestFailures in Inflight. * updated ReorderBetweenGroupsShouldNotOccurWhenCanMixGroupsIsFalse ios image * Updated EntryClearButtonColorShouldMatchTextColor mac image
github-actions bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
* Resolved the ScrollView TestFailures in Inflight. * updated ReorderBetweenGroupsShouldNotOccurWhenCanMixGroupsIsFalse ios image * Updated EntryClearButtonColorShouldMatchTextColor mac image
github-actions bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
* Resolved the ScrollView TestFailures in Inflight. * updated ReorderBetweenGroupsShouldNotOccurWhenCanMixGroupsIsFalse ios image * Updated EntryClearButtonColorShouldMatchTextColor mac image
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ScrollViewInitiallyNotEnabledThenEnabled and ScrollViewInitiallyNotEnabled failing cases in PR #28486
The test cases ScrollViewInitiallyNotEnabledThenEnabled and ScrollViewInitiallyNotEnabled are failing due to the changes introduced in #27231
For the ReorderBetweenGroupsShouldNotOccurWhenCanMixGroupsIsFalse test, there is a slight difference in the expected image on iOS. The image needs to be re-saved to match the expected result.
Updating the screenshot for EntryClearButtonColorShouldMatchTextColor as the current macOS behavior selects the entire text in the Entry when it gains focus.