Introduce SetterSpecificity.FromUnknown to avoid misuse of FromHandler #30122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested review from
StephaneDelcroix
and removed request for
Aguilex and
tj-devel709
PureWeen
added
platform/macos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Adds a new
SetterSpecificity.FromUnknownfor cases where a value needs to be applied with higher priority but should still be overridable by everything else, includingFromHandler.This addresses current misuse of
SetterSpecificity.FromHandlerin scenarios that are not actually coming from the platform/handler.These usages are not handler-driven updates. Overloading FromHandler here undermines its intent and blocks necessary changes (like in #29970) to prevent round-trips in handler-property mappings.
Issues Fixed
Contributes to #29970
Contributes to #22585