[iOS, Mac, Windows] Fixed GraphicsView does not change the Background/BackgroundColor #31254
+186
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
community ✨
jsuarezruiz
added
the
area-drawing
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
suggested changes
Aug 26, 2025
| return new PlatformTouchGraphicsView(); | ||
| } | ||
|
|
||
| public override bool NeedsContainer => VirtualView?.Background is not null || base.NeedsContainer; |
Contributor
There was a problem hiding this comment.
Could include a comment here explaining why we require the Container with a Background?
Contributor
Author
There was a problem hiding this comment.
@jsuarezruiz , Comment added. Please let me know if you have any concerns.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
suggested changes
Sep 8, 2025
Contributor
jsuarezruiz
left a comment
jsuarezruiz
left a comment
There was a problem hiding this comment.
Pending snapshots on Mac and Windows.
Already available in the latest build. Could you commit the images?
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
reviewed
Sep 10, 2025
| override Microsoft.Maui.Handlers.GraphicsViewHandler.ConnectHandler(Microsoft.Maui.Platform.PlatformTouchGraphicsView! platformView) -> void | ||
| override Microsoft.Maui.Handlers.GraphicsViewHandler.CreatePlatformView() -> Microsoft.Maui.Platform.PlatformTouchGraphicsView! | ||
| override Microsoft.Maui.Handlers.GraphicsViewHandler.DisconnectHandler(Microsoft.Maui.Platform.PlatformTouchGraphicsView! platformView) -> void | ||
| override Microsoft.Maui.Handlers.GraphicsViewHandler.NeedsContainer.get -> bool |
Member
There was a problem hiding this comment.
Don't add these to publish shipped
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
This pull request addresses an issue where the
GraphicsViewcontrol did not properly apply or update itsBackgroundorBackgroundColorproperties on iOS, macOS, and Windows platforms. The changes introduce a new test case to verify the fix, update platform-specific handlers to ensure backgrounds are rendered and updated correctly, and make sure the handler uses a container when needed for background rendering.GraphicsView background rendering and updates:
Issue31239) and corresponding drawable to verify thatGraphicsViewcorrectly applies and updates itsBackgroundandBackgroundColorproperties. This includes a UI for dynamic property changes and a button to trigger updates.Issue31239) to automatically verify that background changes are visually applied, with screenshots before and after changing properties.Platform handler improvements:
NeedsContainerproperty inGraphicsViewHandlerto returntruewhen a background is set, ensuring proper rendering. [1] [2]Backgroundproperty changes.Backgroundproperty changes.Validated the behaviour in the following platforms
Regression PR - #26368
Issues Fixed
Fixes #31239
Output
Before.mov
After.mov