Fix RTL label padding on iOS and Android #32333
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects label padding handling in RTL mode by using SetPaddingRelative on Android and flipping left/right insets on iOS. Adds test cases and UI tests to verify correct padding mirroring for labels in RTL layouts.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue where label padding does not properly mirror in RTL (right-to-left) mode on iOS and Android platforms. The fix ensures that when a layout direction is set to RTL, the left and right padding values are swapped appropriately.
Key Changes:
- iOS: Modified
MauiLabel.DrawTextto swap left/right insets when in RTL layout direction - Android: Changed
SetPaddingtoSetPaddingRelativeto use Android's built-in RTL support - Added UI tests to validate RTL padding behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Core/src/Platform/iOS/MauiLabel.cs | Adds RTL-aware inset flipping logic to swap left/right text insets when layout direction is RTL |
| src/Core/src/Platform/Android/TextViewExtensions.cs | Changes from absolute padding to relative padding method for automatic RTL support |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32316.cs | Adds NUnit test implementation to validate RTL padding behavior |
| src/Controls/tests/TestCases.HostApp/Issues/Issue32316.cs | Creates test UI page demonstrating label padding with RTL flow direction toggling |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Nov 3, 2025
| { | ||
| App.WaitForElement("ToggleFlowDirectionButton"); | ||
| App.Tap("ToggleFlowDirectionButton"); | ||
| VerifyScreenshot(); |
Contributor
There was a problem hiding this comment.
Pending snapshots, running a build.
Contributor
There was a problem hiding this comment.
Snapshots are available in the latest build.
Could you commit the images?
Member
|
/azp run MAUI-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Corrects label padding handling in RTL mode by using SetPaddingRelative on Android and flipping left/right insets on iOS. Adds test cases and UI tests to verify correct padding mirroring for labels in RTL layouts.
Issues Fixed
Fixes #32316