[Android] Optimize MauiWindowInsetListener registry with ConditionalWeakTable #32447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Addresses performance concern from #32278 (comment).
The
FindListenerForViewmethod had O(n*m) complexity due to nested iteration:Changes:
List<ViewEntry>withConditionalWeakTable<AView, MauiWindowInsetListener>ViewEntryrecord and manual weak reference managementRegisterView,UnregisterView, andFindListenerForViewto use dictionary operationsPerformance impact:
Code change:
Net: -36 lines, eliminates hot path overhead in deep view hierarchies.
Issues Fixed
Implements optimization suggested in #32278 (comment 3504288138)
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/dotnet/maui/issues/32278/commentscurl -s REDACTED(http block)https://api.github.com/repos/dotnet/maui/issues/comments/3504288138curl -s REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.