Fix error message for non-Windows OS #12046
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -248,7 +249,7 @@ private IList<String> GetPaths(string rootPath, string targetFrameworkFallbackSe | |||
| { | |||
| // No reference assembly paths could be found, log an error so an invalid build will not be produced. | |||
| // 1/26/16: Note this was changed from a warning to an error (see GitHub #173). | |||
| if (pathsToReturn.Count == 0) | |||
| if (pathsToReturn.Count == 0 && RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) | |||
There was a problem hiding this comment.
Suggested change
| if (pathsToReturn.Count == 0 && RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) | |
| if (pathsToReturn.Count == 0 && NativeMethodsShared.IsWindows) |
There was a problem hiding this comment.
Thank you, I wasn't sure if I should use RuntimeInformation and that's definitely look better
abulyaev
force-pushed
the
fix-non-windows-os-error-msg
branch
from
c0de58b to
e1af409
Compare
| @@ -248,7 +248,7 @@ private IList<String> GetPaths(string rootPath, string targetFrameworkFallbackSe | |||
| { | |||
| // No reference assembly paths could be found, log an error so an invalid build will not be produced. | |||
| // 1/26/16: Note this was changed from a warning to an error (see GitHub #173). | |||
| if (pathsToReturn.Count == 0) | |||
| if (pathsToReturn.Count == 0 && NativeMethodsShared.IsWindows) | |||
There was a problem hiding this comment.
I'd still like to return an error in the non-Windows case. It just shouldn't reference installing Windows-only targeting packs.
| @@ -248,7 +248,7 @@ private IList<String> GetPaths(string rootPath, string targetFrameworkFallbackSe | |||
| { | |||
| // No reference assembly paths could be found, log an error so an invalid build will not be produced. | |||
| // 1/26/16: Note this was changed from a warning to an error (see GitHub #173). | |||
| if (pathsToReturn.Count == 0) | |||
| if (pathsToReturn.Count == 0 && NativeMethodsShared.IsWindows) | |||
There was a problem hiding this comment.
Is the right condition here IsWindows, or #if NET? Does the find-targeting-packs code work on Windows/net9?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6647
Context
We shouldn't show error about Developer Pack on non-Windows OSes. This message is reasonable for Windows scenarios, but since there are no .NET Framework Developer or Targeting Packs for Linux or macOS, we shouldn't mention them in that circumstance.
Error message:
error MSB3644: The reference assemblies for .NETFramework,Version=v4.8 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacksChanges Made
Check added to determine if the OS is Windows
Testing
Tests passed
Notes
I assumed we also shouldn't show GetReferenceAssemblyPaths.OutOfDateSDK error if it's not Windows but I can change that if its not true