Skip to content

Turn off node-snapshot on Windows to fix linker error in mksnapshot #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dotnet/main
Choose a base branch
from
Draft

Turn off node-snapshot on Windows to fix linker error in mksnapshot #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion node.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@
<VcBuildCommand>$(VcBuildCommand) vs2022</VcBuildCommand>
</PropertyGroup>
<Message Importance="High" Text="** Running $(VcBuildCommand)" />
<Exec Command="$(VcBuildCommand)"

Check failure on line 74 in node.proj

View check run for this annotation

Azure Pipelines / node-ci (Build Windows x64)

node.proj#L74 

node.proj(74,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ".\vcbuild.bat release x64 openssl-no-asm small-icu static vs2022" exited with code 1.

Check failure on line 74 in node.proj

View check run for this annotation

Azure Pipelines / node-ci (Build Windows arm64)

node.proj#L74 

node.proj(74,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ".\vcbuild.bat release arm64 openssl-no-asm small-icu static vs2022" exited with code 1.

Check failure on line 74 in node.proj

View check run for this annotation

Azure Pipelines / node-ci

node.proj#L74 

node.proj(74,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ".\vcbuild.bat release x64 openssl-no-asm small-icu static vs2022" exited with code 1.

Check failure on line 74 in node.proj

View check run for this annotation

Azure Pipelines / node-ci

node.proj#L74 

node.proj(74,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ".\vcbuild.bat release arm64 openssl-no-asm small-icu static vs2022" exited with code 1.
IgnoreStandardErrorWarningFormat="true"
EnvironmentVariables="PATH=$([MSBuild]::Escape($(PythonPrefixedPath)))" />
EnvironmentVariables="PATH=$([MSBuild]::Escape($(PythonPrefixedPath)));config_flags=--without-node-snapshot" />
</Target>

<Target Name="LayoutNodeWindows" AfterTargets="ReallyBuildWindows" Condition="'$(BuildOS)' == 'Windows_NT'">
Expand Down