Skip to content

Add flaky on VM to some SSL tests #4751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add flaky on VM to some SSL tests #4751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/benchmarks/micro/libraries/System.Net.Security/SslStreamTests.Protocols.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,22 +32,23 @@ public static IEnumerable<object[]> TlsProtocols()

[Benchmark]
[ArgumentsSource(nameof(TlsProtocols))]
[BenchmarkCategory(Categories.NoAOT)]
[BenchmarkCategory(Categories.NoAOT, Categories.FlakyOnVM)]
public Task HandshakeECDSA256CertAsync(SslProtocols protocol) => SslStreamTests.HandshakeAsync(SslStreamTests._ec256Cert, protocol);

[Benchmark]
[ArgumentsSource(nameof(TlsProtocols))]
[BenchmarkCategory(Categories.NoAOT)]
[BenchmarkCategory(Categories.NoAOT, Categories.FlakyOnVM)]
[OperatingSystemsFilter(allowed: true, platforms: OS.Linux)] // Not supported on Windows at the moment.
public Task HandshakeECDSA512CertAsync(SslProtocols protocol) => SslStreamTests.HandshakeAsync(SslStreamTests._ec512Cert, protocol);

[Benchmark]
[ArgumentsSource(nameof(TlsProtocols))]
[BenchmarkCategory(Categories.NoAOT)]
[BenchmarkCategory(Categories.NoAOT, Categories.FlakyOnVM)]
public Task HandshakeRSA2048CertAsync(SslProtocols protocol) => SslStreamTests.HandshakeAsync(SslStreamTests._rsa2048Cert, protocol);

[Benchmark]
[ArgumentsSource(nameof(TlsProtocols))]
[BenchmarkCategory(Categories.NoAOT, Categories.FlakyOnVM)]
public Task HandshakeRSA4096CertAsync(SslProtocols protocol) => SslStreamTests.HandshakeAsync(SslStreamTests._rsa4096Cert, protocol);

private static bool GetTls13Support()
Expand Down
Loading