Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate ApplicationPropertyPage in code. #7922

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Recreate ApplicationPropertyPage in code. #7922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...ft.VisualStudio.ProjectSystem.Managed/Microsoft.VisualStudio.ProjectSystem.Managed.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,11 @@
<Generator>MSBuild:GenerateRuleSourceFromXaml</Generator>
<SubType>Designer</SubType>
</XamlPropertyRule>
<Compile Update="ProjectSystem\Rules\PropertyPages\PropertyPageResources.Designer.cs">
<DesignTime>True</DesignTime>
<AutoGen>True</AutoGen>
<DependentUpon>PropertyPageResources.resx</DependentUpon>
</Compile>

<Compile Update="ProjectSystem\Rules\ResolvedCompilationReference.cs">
<DependentUpon>ResolvedCompilationReference.xaml</DependentUpon>
Expand Down Expand Up @@ -593,6 +598,10 @@
</ItemGroup>

<ItemGroup>
<EmbeddedResource Update="ProjectSystem\Rules\PropertyPages\PropertyPageResources.resx">
<Generator>ResXFileCodeGenerator</Generator>
<LastGenOutput>PropertyPageResources.Designer.cs</LastGenOutput>
</EmbeddedResource>
<EmbeddedResource Update="Resources.resx">
<Generator>ResXFileCodeGenerator</Generator>
<LastGenOutput>Resources.Designer.cs</LastGenOutput>
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/ProjectCapability.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ internal static class ProjectCapability
public const string CSharpAppDesigner = ProjectCapabilities.CSharp + " & " + AppDesigner;
public const string FSharpAppDesigner = FSharp + " & " + AppDesigner;
public const string CSharpOrVisualBasic = "(" + ProjectCapabilities.CSharp + " | " + ProjectCapabilities.VB + ")";
public const string CSharpOrVisualBasicOrFSharp = "(" + ProjectCapabilities.CSharp + " | " + ProjectCapabilities.VB + " | " + FSharp + ")";
public const string CSharpOrVisualBasicLanguageService = CSharpOrVisualBasic + " & " + LanguageService;

public const string AppDesigner = nameof(AppDesigner);
Expand Down
257 changes: 257 additions & 0 deletions ...Studio.ProjectSystem.Managed/ProjectSystem/Rules/PropertyPages/ApplicationPropertyPage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,257 @@
// Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE.md file in the project root for more information.

using System;
using System.Collections.Generic;
using Microsoft.Build.Framework.XamlTypes;
using Microsoft.VisualStudio.ProjectSystem.Properties;
using PPR = Microsoft.VisualStudio.ProjectSystem.Rules.PropertyPages.PropertyPageResources;

namespace Microsoft.VisualStudio.ProjectSystem.Rules.PropertyPages
{
internal static class PropertyMetadata
{
public static readonly string VisibilityCondition = "VisibilityCondition";
public static readonly string SearchTerms = "SearchTerms";
public static readonly string DependsOn = "DependsOn";
}

// TODO: The context could come from a constant.
[ExportRuleObjectProvider(name: "DefaultApplicationPropertyPageProvider", context: "Project")]
[AppliesTo(ProjectCapability.CSharpOrVisualBasicOrFSharp)]
[Order(Order.Default)]
internal sealed class ApplicationPropertyPageProvider : IRuleObjectProvider
{
private const string GeneralCategoryName = "General";
private const string ResourcesCategoryName = "Resources";
private const string PackagingCategoryName = "Packaging";

private readonly Lazy<List<Rule>> _rules = new(CreateRules);

private static List<Rule> CreateRules()
{
Rule rule = new();

rule.BeginInit();

rule.Name = "Application";
rule.Description = PPR.ApplicationPage_Description;
rule.DisplayName = PPR.ApplicationPage_DisplayName;
// TODO: The PageTemplate could come from a constant.
rule.PageTemplate = "generic";
rule.Order = 100;

rule.Categories = new()
{
CreateCategory(
name: GeneralCategoryName,
displayName: PPR.ApplicationPage_GeneralCategory_DisplayName,
description: PPR.ApplicationPage_GeneralCategory_Description),
CreateCategory(
name: ResourcesCategoryName,
displayName: PPR.ApplicationPage_ResourcesCategory_DisplayName,
description: PPR.ApplicationPage_ResourcesCategory_Description),
CreateCategory(
name: PackagingCategoryName,
displayName: PPR.ApplicationPage_PackagingCategory_DisplayName,
description: PPR.ApplicationPage_PackagingCategory_Description)
};

rule.DataSource = new()
{
// TODO: The Persistence could come from a constant.
Persistence = "ProjectFile",
SourceOfDefaultValue = DefaultValueSourceLocation.AfterContext,
HasConfigurationCondition = false
};

EnumProperty outputTypeProperty = new()
{
Name = "OutputType",
DisplayName = PPR.ApplicationPage_OutputTypeProperty_DisplayName,
Description = PPR.ApplicationPage_OutputTypeProperty_Description,
Category = GeneralCategoryName,
AdmissibleValues =
{
new() { Name = "Library", DisplayName = PPR.ApplicationPage_OutputTypeProperty_LibraryValue_DisplayName },
new() { Name = "Exe", DisplayName = PPR.ApplicationPage_OutputTypeProperty_ExeValue_DisplayName },
new() { Name = "WinExe", DisplayName = PPR.ApplicationPage_OutputTypeProperty_WinExeValue_DisplayName }
}
};

BoolProperty targetMultipleFrameworksProperty = new()
{
Name = "TargetMultipleFrameworks",
DisplayName = PPR.ApplicationPage_TargetMultipleFrameworksProperty_DisplayName,
Description = PPR.ApplicationPage_TargetMultipleFrameworksProperty_Description,
HelpUrl = "https://go.microsoft.com/fwlink/?linkid=2147236",
Category = GeneralCategoryName,
Visible = false,
DataSource = new()
{
Persistence = "ProjectFileWithInterception",
HasConfigurationCondition = false
}
};

DynamicEnumProperty interceptedTargetFrameworkProperty = new()
{
Name = "InterceptedTargetFramework",
DisplayName = PPR.ApplicationPage_InterceptedTargetFrameworkProperty_DisplayName,
Description = PPR.ApplicationPage_InterceptedTargetFrameworkProperty_Description,
HelpUrl = "https://go.microsoft.com/fwlink/?linkid=2147236",
Category = GeneralCategoryName,
EnumProvider = "SupportedTargetFrameworksEnumProvider",
MultipleValuesAllowed = false,
DataSource = new()
{
Persistence = "ProjectFileWithInterception",
HasConfigurationCondition = false
},
Metadata =
{
new() { Name = PropertyMetadata.VisibilityCondition, Value = "(not (has-evaluated-value \"Application\" \"TargetMultipleFrameworks\" true))" },
new() { Name = PropertyMetadata.SearchTerms, Value = PPR.ApplicationPage_InterceptedTargetFrameworkProperty_SearchTerms },
new() { Name = PropertyMetadata.DependsOn, Value = "Application::TargetMultipleFrameworks" }
}
};

StringProperty targetFrameworksProperty = new()
{
Name = "TargetFrameworks",
DisplayName = PPR.ApplicationPage_TargetFrameworksProperty_DisplayName,
Description = PPR.ApplicationPage_TargetFrameworksProperty_Description,
HelpUrl = "https://go.microsoft.com/fwlink/?linkid=2147236",
Category = GeneralCategoryName,
DataSource = new()
{
Persistence = "ProjectFileWithInterception",
HasConfigurationCondition = false
},
Metadata =
{
new() { Name = PropertyMetadata.VisibilityCondition, Value = "(has-evaluated-value \"Application\" \"TargetMultipleFrameworks\" true)" },
new() { Name = PropertyMetadata.SearchTerms, Value = PPR.ApplicationPage_TargetFrameworksProperty_SearchTerms },
new() { Name = PropertyMetadata.DependsOn, Value = "Application::TargetMultipleFrameworks" }
}
};

StringProperty installOtherFrameworksProperty = new()
{
Name = "InstallOtherFrameworks",
DisplayName = PPR.ApplicationPage_InstallOtherFrameworksProperty_DisplayName,
Category = GeneralCategoryName,
DataSource = new()
{
PersistedName = "InstallOtherFrameworks",
Persistence = "ProjectFileWithInterception",
HasConfigurationCondition = false
},
ValueEditors =
{
new()
{
// TODO: EditorType could come from a constant
EditorType = "LinkAction",
Metadata =
{
new() { Name = "Action", Value = "URL" },
new() { Name = "URL", Value = "http://go.microsoft.com/fwlink/?LinkID=287120" }
}
}
Comment on lines +151 to +160
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some helper methods for this kind of thing could be helpful.

This could be written as:

Suggested change
new()
{
// TODO: EditorType could come from a constant
EditorType = "LinkAction",
Metadata =
{
new() { Name = "Action", Value = "URL" },
new() { Name = "URL", Value = "http://go.microsoft.com/fwlink/?LinkID=287120" }
}
}
HyperlinkActionEditor("http://go.microsoft.com/fwlink/?LinkID=287120")

}
};

DynamicEnumProperty targetPlatformIdentifierProperty = new()
{
Name = "TargetPlatformIdentifier",
DisplayName = PPR.ApplicationPage_TargetPlatformIdentifierProperty_DisplayName,
Description = PPR.ApplicationPage_TargetPlatformIdentifierProperty_Description,
Category = GeneralCategoryName,
EnumProvider = "SdkSupportedTargetPlatformIdentifierEnumProvider",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could be constants on the provider classes.

HelpUrl = "https://go.microsoft.com/fwlink/?linkid=2184943",
DataSource = new()
{
Persistence = "ProjectFileWithInterception",
HasConfigurationCondition = false
},
Metadata = new()
{
new() { Name = PropertyMetadata.SearchTerms, Value = PPR.ApplicationPage_TargetPlatformIdentifierProperty_SearchTerms },
new()
{
Name = PropertyMetadata.VisibilityCondition,
Value = @"
(and
(has-net-core-app-version-or-greater ""5.0"")
(not (has-evaluated-value ""Application"" ""TargetMultipleFrameworks"" true)))
"
}
}
};

DynamicEnumProperty targetPlatformVersionProperty = new()
{
Name = "TargetPlatformVersion",
DisplayName = PPR.ApplicationPage_TargetPlatformVersionProperty_DisplayName,
Description = PPR.ApplicationPage_TargetPlatformVersionProperty_Description,
Category = GeneralCategoryName,
EnumProvider = "SdkSupportedTargetPlatformVersionEnumProvider",
HelpUrl = "https://go.microsoft.com/fwlink/?linkid=2185153",
DataSource = new()
{
Persistence = "ProjectFileWithInterception",
HasConfigurationCondition = false
},
Metadata = new()
{
new()
{
Name = PropertyMetadata.VisibilityCondition,
Value =
@"
(and
(has-net-core-app-version-or-greater ""5.0"")
(and
(ne (unevaluated ""Application"" ""TargetPlatformIdentifier"") """")
(not (has-evaluated-value ""Application"" ""TargetMultipleFrameworks"" true))))
"
},
new() { Name = PropertyMetadata.SearchTerms, Value = PPR.ApplicationPage_TargetPlatformVersionProperty_SearchTerms },
new() { Name = PropertyMetadata.DependsOn, Value = "Application::TargetPlatformIdentifier" }
}
};

rule.Properties = new()
{
outputTypeProperty,
targetMultipleFrameworksProperty,
interceptedTargetFrameworkProperty,
targetFrameworksProperty,
installOtherFrameworksProperty,
targetPlatformIdentifierProperty,
targetPlatformVersionProperty,

};

rule.EndInit();

List<Rule> rules = new();
rules.Add(rule);

return rules;
}

private static Category CreateCategory(string name, string displayName, string description)
{
Category category = new();
category.BeginInit();
category.Name = name;
category.DisplayName = displayName;
category.Description = description;
category.EndInit();
return category;
}

public IReadOnlyCollection<Rule> GetRules() => _rules.Value;
}
}
Loading