Fix WPF application framework re-enable bug #9256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub.com/haileymck/project-system into wpf-application-framework-enable-disable
drewnoakes
reviewed
Sep 7, 2023
...es/InterceptedProjectProperties/ApplicationPropertyPage/ApplicationFrameworkValueProvider.cs
Outdated
Show resolved
Hide resolved
...es/InterceptedProjectProperties/ApplicationPropertyPage/ApplicationFrameworkValueProvider.cs
Outdated
Show resolved
Hide resolved
...es/InterceptedProjectProperties/ApplicationPropertyPage/ApplicationFrameworkValueProvider.cs
Outdated
Show resolved
Hide resolved
...es/InterceptedProjectProperties/ApplicationPropertyPage/ApplicationFrameworkValueProvider.cs
Outdated
Show resolved
Hide resolved
drewnoakes
added
the
Feature-Project-Properties-Designer
Is it implicitly defined in C# as well? |
|
@haileymck is this still in-progress or has it been shelved? |
going to convert to draft |
adamint
approved these changes
Oct 19, 2023
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#1882665
When you disable and then re-enable "Application Framework" in VB WPF projects, it adds
<ApplicationDefinition Include="Application.xaml" />to the project file, which is already implicitly declared and causes the build to fail. This PR removes this ApplicationDefinition when the property is re-enabled.Note that this change leaves empty
<ItemGroup />in the project file because theItemGroupsis a readonly collection available by MSBuildMicrosoft Reviewers: Open in CodeFlow