Ensure warning message uses local time #9280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#9279 When incremental build failure detection is enabled, we can log a warning that includes paths and timestamps. However if FUTDC logging is disabled, the conversion from UTC to local time could be bypassed, making the log message harder to understand and potentially misleading (as there's no mention of UTC in the message). This change fixes that issue by ensuring any times are converted to local time prior to being displayed.
drewnoakes
added
the
Feature-Up-to-date
smitpatel
approved these changes
Oct 11, 2023
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9279
When incremental build failure detection is enabled, we can log a warning that includes paths and timestamps. However if FUTDC logging is disabled, the conversion from UTC to local time could be bypassed, making the log message harder to understand and potentially misleading (as there's no mention of UTC in the message).
This change fixes that issue by ensuring any times are converted to local time prior to being displayed.
Microsoft Reviewers: Open in CodeFlow