Bump version number to 17.9 #9283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `main` branch is now targeting 17.9; update the version.json accordingly.
haileymck
approved these changes
Oct 12, 2023
|
should we also update the fabricbot.json file? so that PRs are marked with an updated milestone? |
|
Also related changes in project-system-vscode. |
That's on the to-do list (#9282). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Interesting that version number change requires new packages ingestion. |
|
@smitpatel The failures seem to be around authentication, not ingestion. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Add a global.json to force a particular SDK in hopes that resolves issues with NuGet restore.
Remove the global.json. The specified version of the SDK doesn't seem to be installed on the build system, so we don't even get far enough to encounter the NuGet authentication issue I'm seeing.
Currently we exclude the obj directory from the set of artifacts we collect after a build as it contains only intermediate outputs rather than the final outputs in the bin directory. However, those intermediate outputs (such as the project.assets.json file) can be very useful in diagnosing build problems. Here we drop the obj directory exclusion so that we can get a copy of the project.assets.json file from a PR build.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Now that the project.assets.json from the PR build has been investigated we can go back to filtering out the obj directory from artifacts.
Update the PR build to install the version of the .NET runtime used in our unit test runs, specifically, 7.0.x. This wasn't previously needed, so I can only guess that the build system image we were using came with it preinstalled. It seems we can no longer count on that, so now we will explicitly install it. Without this our unit tests fail to run due to a lack of a runtime.
drewnoakes
approved these changes
Oct 15, 2023
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mainbranch is now targeting 17.9; update the version.json accordingly.Microsoft Reviewers: Open in CodeFlow