Remove dependency upon Microsoft.VisualStudio.SDK.EmbedInteropTypes #9289
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| in the EmbedInteropTypes package and ensure only the dependencies we need are embedded and the others are | ||
| skipped. | ||
| --> | ||
| <Target Name="CustomLinkVSSDKEmbeddableAssemblies" AfterTargets="LinkVSSDKEmbeddableAssemblies"> |
There was a problem hiding this comment.
Are we sure this is no longer needed? While we may no longer need Microsoft.VisualStudio.SDK.EmbedInteropTypes, I would expect we still need to be careful about what we do or do not embed.
There was a problem hiding this comment.
It should be a simple matter to search for each of these target names in the codebase (or a binlog file) to see if anyone references them.
There was a problem hiding this comment.
I suppose the definitive answer would be to build with and without this change and see if there are changes in what gets embedded.
Though if the guidance for 64-bit VS is to not embed interop types and that is the default behavior then we're probably best off removing all of this non-default embedded behavior and just dealing with the fallout (if any).
Fixes #9286
Microsoft Reviewers: Open in CodeFlow