Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make verified files as lf and utf8 #9498

Merged
merged 3 commits into from
Jul 23, 2024
Merged

make verified files as lf and utf8 #9498

merged 3 commits into from
Jul 23, 2024

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Jul 5, 2024 •
edited by dotnet-policy-service bot
Loading

@SimonCropp SimonCropp requested a review from a team as a code owner July 5, 2024 10:11
drewnoakes
drewnoakes approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much Simon. We were hitting issues updating Verify and this might well be the reason. Will try and revive that PR once this merges.

@drewnoakes drewnoakes merged commit db551d8 into dotnet:main Jul 23, 2024
5 checks passed
@drewnoakes
Copy link
Member

Bumping to latest Verify requires bumping xunit too, which is blocked in #9457. Will revisit in future.

@drewnoakes drewnoakes mentioned this pull request Jul 23, 2024
Open
@SimonCropp
Copy link
Contributor Author

@drewnoakes this PR doesnt bump verify. these settings work back several years with of Verify versions

@SimonCropp SimonCropp deleted the make-verified-files-as-lf-and-utf8 branch July 23, 2024 06:00
@drewnoakes
Copy link
Member

Understood. What I meant was that we had previously hit issues when trying to bump Verify (#9056 (comment)).

We are currently seeing issues upgrading xunit (#9457 (comment)). Once that is addressed, we can try updating Verify to the latest too.

Thanks again for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewnoakes drewnoakes drewnoakes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonCropp @drewnoakes