Implement IManagedHotReloadAgent2 and IManagedHotReloadAgent4 for ProjectHotReloadSession #9555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can use "blame" on the WebTools source to see it was added in 2022 with this PR https://devdiv.visualstudio.com/DevDiv/_git/WebTools/pullrequest/371614 in response to bug https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1453640/ I don't know more than that though. |
drewnoakes
previously approved these changes
Oct 11, 2024
...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSessionManager.cs
Outdated
Show resolved
Hide resolved
LittleLittleCloud
changed the title
tmat
reviewed
Oct 15, 2024
tmat
reviewed
Oct 15, 2024
drewnoakes
dismissed
their stale review
Code has changed quite a bit since then. Will review again once the PR is published.
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9555 in repo dotnet/project-system |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drewnoakes
reviewed
Nov 12, 2024
....VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSession.cs
Outdated
Show resolved
Hide resolved
....VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSession.cs
Outdated
Show resolved
Hide resolved
...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSessionManager.cs
Outdated
Show resolved
Hide resolved
drewnoakes
reviewed
Nov 13, 2024
...ft.VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadAgent.cs
Outdated
Show resolved
Hide resolved
drewnoakes
reviewed
Nov 13, 2024
...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSessionManager.cs
Outdated
Show resolved
Hide resolved
drewnoakes
reviewed
Nov 13, 2024
....VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSession.cs
Outdated
Show resolved
Hide resolved
drewnoakes
reviewed
Nov 13, 2024
...crosoft.VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Build/SolutionBuildManager.cs
Outdated
Show resolved
Hide resolved
drewnoakes
reviewed
Nov 13, 2024
...udio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/IProjectHotReloadSessionCallback.cs
Outdated
Show resolved
Hide resolved
drewnoakes
reviewed
Nov 13, 2024
....VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSession.cs
Outdated
Show resolved
Hide resolved
drewnoakes
reviewed
Nov 13, 2024
...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSessionManager.cs
Outdated
Show resolved
Hide resolved
…tem/VS/HotReload/ProjectHotReloadSession.cs Co-authored-by: Drew Noakes <[email protected]>
…tem/VS/HotReload/IProjectHotReloadSessionCallback.cs Co-authored-by: Drew Noakes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
IManagedHotReloadAgent4forProjectHotReloadSession. So that debugger can query it for the full path to its csproj file and use it for restarting the corresponding project.