Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make build property CompilerGeneratedFilesOutputPath accessible to Roslyn project" #9579

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Nov 1, 2024

Reverts #9544

This change was triggering a failure in Roslyn around use of EmitCompilerGeneratedFiles, leading to project faults resembling:

System.ArgumentException: Absolute path expected
Parameter name: path
  at Microsoft.CodeAnalysis.CompilationOutputInfo.WithGeneratedFilesOutputDirectory(String path)
  at Microsoft.CodeAnalysis.Workspaces.ProjectSystem.ProjectSystemProject.<>c__DisplayClass69_0.<set_GeneratedFilesOutputDirectory>b__0(Solution s)
...

At the start of October, Roslyn started requiring an absolute path here:

https://github.com/dotnet/roslyn/pull/75311/files#diff-8440787c9215f81fa8cabe9072d5ab0598251313a4480cfca075041ceed8a5bbR41-R44

But by default, the SDK provides a relative path (and indeed all online examples show relative paths here). Only once we inserted #9544

@tmat has a PR open in Roslyn to fix this: https://github.com/dotnet/roslyn/pull/75674/files

Once the Roslyn side is fixed, we can reinstate this change.

Microsoft Reviewers: Open in CodeFlow

@drewnoakes drewnoakes requested a review from a team as a code owner November 1, 2024 04:25
@davkean davkean self-requested a review November 1, 2024 04:26
@drewnoakes drewnoakes merged commit 9f35656 into main Nov 1, 2024
6 checks passed
@drewnoakes drewnoakes deleted the revert-9544-CompilerGeneratedFilesOutputPath branch November 1, 2024 04:48
@dotnet-policy-service dotnet-policy-service bot added this to the 17.12 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants