Set AsyncLazy.SuppressRecursiveFactoryDetection to true #9624
+43
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the overhead associated with the type's re-entrancy prevention in cases where we the code cannot call itself. See microsoft/vs-threading#1265 for more information.
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/Debug/DebugProfileEnumValuesGenerator.cs:28
- The use of '[]' to initialize an empty array is incorrect. It should be 'Array.Empty()'.
? []
...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/Query/PropertyPages/AbstractProjectState.cs
Show resolved
Hide resolved
...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/Query/PropertyPages/AbstractProjectState.cs
Show resolved
Hide resolved
drewnoakes
added
the
Tenet-Performance
LittleLittleCloud
approved these changes
Dec 18, 2024
haileymck
approved these changes
Dec 18, 2024
melytc
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the overhead associated with the type's re-entrancy prevention in cases where we the code cannot call itself.
See microsoft/vs-threading#1265 for more information.
@lifengl proposed this improvement as part of #9623. One occurrence is addressed in that PR. Others are here in this PR.
Microsoft Reviewers: Open in CodeFlow