Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cohosting tests for Uri presentation #10642

Merged
merged 6 commits into from
Jul 19, 2024

Conversation

davidwengier
Copy link
Contributor

@davidwengier davidwengier commented Jul 18, 2024

Part of #9519 and #10603

After this, all cohost endpoints have test coverage 😁

@davidwengier
Copy link
Contributor Author

Thought of a missing test case, added it, found a product bug! This whole testing malarky works, who knew?!

@davidwengier
Copy link
Contributor Author

@DustinCampbell curious if you have any thoughts about the last commit? Eventually we might need something that can be used by multiple services, to control whether their endpoints should do further processing, so we can flesh this out later, I'm mainly curious if you are staunchly against me defining a record inside an interface :)

@DustinCampbell
Copy link
Member

@DustinCampbell curious if you have any thoughts about the last commit? Eventually we might need something that can be used by multiple services, to control whether their endpoints should do further processing, so we can flesh this out later, I'm mainly curious if you are staunchly against me defining a record inside an interface :)

I'm good with the change you made. I agree that we'll need something that can be used by other services later. I have no problem with types defined inside interfaces. 😄

@davidwengier davidwengier merged commit a12e07b into dotnet:main Jul 19, 2024
12 checks passed
@davidwengier davidwengier deleted the CohostUriPresentationTests branch July 19, 2024 03:55
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 19, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 Preview 1 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants