Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cohosting OnAutoInsert endpoint #10674

Closed
wants to merge 38 commits into from
Closed

Cohosting OnAutoInsert endpoint #10674

wants to merge 38 commits into from
+1,349 −613

Commits on Aug 21, 2024

  1. Factoring out AutoInsertService

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    7d63bd4 View commit details
    Browse the repository at this point in the history

  2. Switch non-cohost endpoint to use new AutoInsertService

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    7e736cf View commit details
    Browse the repository at this point in the history

  3. Adding Remote and OOB AutoInsertService classes and OnAutoInsertProvi… 

    …ders
    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    c2ad4ed View commit details
    Browse the repository at this point in the history

  4. Add common code for capabilities

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    ce9e1bf View commit details
    Browse the repository at this point in the history

  5. Add cohost OnAutoInsert endpoint

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    72fdab3 View commit details
    Browse the repository at this point in the history

  6. Parameter rename

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    c3c72dc View commit details
    Browse the repository at this point in the history

  7. Update src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/AutoInse… 

    …rt/AutoClosingTagOnAutoInsertProvider.cs

Co-authored-by: David Wengier <[email protected]>
    @alexgav @davidwengier
    alexgav and davidwengier committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4350c85 View commit details
    Browse the repository at this point in the history

  8. Update src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/AutoInse… 

    …rt/IAutoInsertService.cs

Co-authored-by: David Wengier <[email protected]>
    @alexgav @davidwengier
    alexgav and davidwengier committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    3dbaf87 View commit details
    Browse the repository at this point in the history

  9. Update src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/AutoInse… 

    …rt/InsertTextEdit.cs

Co-authored-by: David Wengier <[email protected]>
    @alexgav @davidwengier
    alexgav and davidwengier committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    0df70d6 View commit details
    Browse the repository at this point in the history

  10. Fixup after rebase

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    32eb28f View commit details
    Browse the repository at this point in the history

  11. More post-build cleanup

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    5c1deb6 View commit details
    Browse the repository at this point in the history

  12. Move common HTML and C# auto-insert trigger chars per CR suggestion

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    71fe24e View commit details
    Browse the repository at this point in the history

  13. More cleanup after rebase

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    177c0f4 View commit details
    Browse the repository at this point in the history

  14. Add IOnAutoInsertTiggerCharacterProvider per CR suggestion

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    1dc1044 View commit details
    Browse the repository at this point in the history

  15. Removing trigger characters property from RemoteAutoInsertService per… 

    … CR suggestion
    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4988389 View commit details
    Browse the repository at this point in the history

  16. Switch to using RemoteResponse

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    325b59f View commit details
    Browse the repository at this point in the history

  17. Fixup bad resolve after rebase, and extra whitespace in RazorLangauge… 

    …Server
    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d4bbe6c View commit details
    Browse the repository at this point in the history

  18. Complete capabilities check in CohostingOnAutoInsertEndpoing registra… 

    …tion
    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    bb7f79e View commit details
    Browse the repository at this point in the history

  19. Change input position type to serializable :LinePosition

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4e0d7b2 View commit details
    Browse the repository at this point in the history

  20. Fixing RemoteInsertTextEdit to use properly annotated (for serializat… 

    …ion) types only
    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    72923a4 View commit details
    Browse the repository at this point in the history

  21. Support for delegating auto-insert to C#

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    b230260 View commit details
    Browse the repository at this point in the history

  22. Fixup after rebase

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d8ab694 View commit details
    Browse the repository at this point in the history

  23. Fixup AutoClosingTagOnAutoInsertProviderTest tests

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    9d3b8fe View commit details
    Browse the repository at this point in the history

  24. Fixinfg up CloseTextTagOnAutoInsertProviderTest tests

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    bc1b677 View commit details
    Browse the repository at this point in the history

  25. Fixing up OnAutoInsertEndpointTest (which also tests the new AutoInse… 

    …rtService)
    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    3a34c6b View commit details
    Browse the repository at this point in the history

  26. Fixing duplicate OnAutoInsert handler registration (bad merge after r… 

    …ebate)
    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    a5ab0df View commit details
    Browse the repository at this point in the history

  27. Fixes to MEF composition issue and capabilities check 

    - IDocumentMappingService was not needed (and not available via MEF), so removed that
- TextDocument does not implmement VSInternalTextDocumentClientCapabilities
    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    356da7c View commit details
    Browse the repository at this point in the history

  28. Fixing incorrect export type

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    37f0d42 View commit details
    Browse the repository at this point in the history

  29. Minor cleanup per CR suggestions

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    52b251f View commit details
    Browse the repository at this point in the history

  30. Switching parameters to RazorCodeDocument and removing async in a lot… 

    … of places per CR suggestion
    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    477585d View commit details
    Browse the repository at this point in the history

  31. Fixing build - removing unneeded using

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    19f4f46 View commit details
    Browse the repository at this point in the history

  32. Fix RemoteAutoInsertService logic to follow existing code (always pre… 

    …fer our own AutoInsertService first)
    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    95c810f View commit details
    Browse the repository at this point in the history

  33. Check allowed trigger characters before delegating to other languages… 

    …/servers
    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    eaf408d View commit details
    Browse the repository at this point in the history

  34. Plumbing through actual option values we need and using them

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    e9c8d54 View commit details
    Browse the repository at this point in the history

  35. Fixup After Rebase

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    53e5186 View commit details
    Browse the repository at this point in the history

  36. Consuming RazorFormattingService in remote OnAutoInsert service

    @alexgav
    alexgav committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    58883fb View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Fixing exception in RemoteProjectSnapshot.Configuration 

    Moving GetFormatterCodeDocumentAsync() into IDocumentSnapshot (and implementations of that) to allow eaiser differentiation of behavior in remote (cohosting) case where we don't need to check the flag on Project.Configuration.

Also AddUsingStatementsIfNeeded *always* gets called, even in cases when they are not actually needed, so we can't Debug.Fail there.
    @alexgav
    alexgav committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7e442d2 View commit details
    Browse the repository at this point in the history

  2. Switch to PreferHtmlInAttributeValuesDocumentPositionInfoStrategy as … 

    …the original code does

That allows the code insert double-quotes by delegating to HTML language server after attribute name and equals.
    @alexgav
    alexgav committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    292c9a7 View commit details
    Browse the repository at this point in the history