-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-architect formatting to prepare for cohosting (and for fun!) #10778
Commits on Aug 21, 2024
-
Move add usings helper code down to the workspaces layer
This commit is just moves, no functionality changes. Minor tweaks to method visibility, and one rename of a static field :)
Configuration menu - View commit details
-
Copy full SHA for 97ac536 - Browse repository at this point
Copy the full SHA 97ac536View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8984db9 - Browse repository at this point
Copy the full SHA 8984db9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fba3f1e - Browse repository at this point
Copy the full SHA fba3f1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c39c20 - Browse repository at this point
Copy the full SHA 2c39c20View commit details -
Configuration menu - View commit details
-
Copy full SHA for e45f094 - Browse repository at this point
Copy the full SHA e45f094View commit details -
Be SUPER specific about our APIs, what they accept, and what they return
This probably looks like overkill, but hopefully the next commit will help explain a little about what is going on.
Configuration menu - View commit details
-
Copy full SHA for a702716 - Browse repository at this point
Copy the full SHA a702716View commit details -
Pass Html edits into the formatting service, so that the service does…
…n't need LSP client dependencies
Configuration menu - View commit details
-
Copy full SHA for e56b85e - Browse repository at this point
Copy the full SHA e56b85eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f57810 - Browse repository at this point
Copy the full SHA 3f57810View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38868db - Browse repository at this point
Copy the full SHA 38868dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca142be - Browse repository at this point
Copy the full SHA ca142beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1143900 - Browse repository at this point
Copy the full SHA 1143900View commit details
Commits on Aug 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2165fcb - Browse repository at this point
Copy the full SHA 2165fcbView commit details -
Be explicit about formatting passes
Always felt like a huge potential bug farm. eg, if Html ended up not being first we'd have bugs, working out the Order property (which was weirdly backwards?) was a pain, and the entire formatting engine produces horrible results if the ordering changes anyway.
Configuration menu - View commit details
-
Copy full SHA for d635754 - Browse repository at this point
Copy the full SHA d635754View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e12117 - Browse repository at this point
Copy the full SHA 4e12117View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f1c6ef - Browse repository at this point
Copy the full SHA 6f1c6efView commit details -
Configuration menu - View commit details
-
Copy full SHA for f74150d - Browse repository at this point
Copy the full SHA f74150dView commit details -
Separate out the files in the Html formatter passes.
Doing this separately, and purely mechanically, so make review easier
Configuration menu - View commit details
-
Copy full SHA for ef44f4f - Browse repository at this point
Copy the full SHA ef44f4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45b8495 - Browse repository at this point
Copy the full SHA 45b8495View commit details -
Remove Kind property from FormattingResult
This was only used for validation as edits pass through the pipeline, but since we now tightly control the pipeline its unnecessary
Configuration menu - View commit details
-
Copy full SHA for 5caa48f - Browse repository at this point
Copy the full SHA 5caa48fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa4e8ef - Browse repository at this point
Copy the full SHA fa4e8efView commit details
Commits on Aug 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 587e72a - Browse repository at this point
Copy the full SHA 587e72aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6622a0f - Browse repository at this point
Copy the full SHA 6622a0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b79428 - Browse repository at this point
Copy the full SHA 3b79428View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2157169 - Browse repository at this point
Copy the full SHA 2157169View commit details
Commits on Aug 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 19134c2 - Browse repository at this point
Copy the full SHA 19134c2View commit details
Commits on Aug 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1de43a0 - Browse repository at this point
Copy the full SHA 1de43a0View commit details
Commits on Aug 29, 2024
-
Merge remote-tracking branch 'upstream/main' into FormattingLayering
# Conflicts: # src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/LanguageServer/RazorCSharpFormattingBenchmark.cs # src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/AutoInsert/OnAutoInsertEndpoint.cs # src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/HtmlFormatter.cs # src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/InlineCompletion/InlineCompletionEndPoint.cs # src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/FormattingContext.cs # src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/IRazorFormattingService.cs # src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/Passes/CSharpFormattingPass.cs # src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/Passes/FormattingContentValidationPass.cs # src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/Passes/FormattingDiagnosticValidationPass.cs # src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/Passes/HtmlFormattingPassBase.cs # src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/RazorFormattingService.cs # src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/Formatting/RemoteCSharpOnTypeFormattingPass.cs # src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/Formatting/RemoteRazorFormattingPass.cs # src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/AutoInsert/RazorOnAutoInsertProviderTestBase.cs # src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Completion/Delegation/DelegatedCompletionItemResolverTest.NetFx.cs # src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/FormattingLanguageServerTestBase.cs # src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/FormattingTestBase.cs # src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/TestRazorFormattingService.cs
Configuration menu - View commit details
-
Copy full SHA for d0e2a57 - Browse repository at this point
Copy the full SHA d0e2a57View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee83a6b - Browse repository at this point
Copy the full SHA ee83a6bView commit details