Adopt WellKnownTypeProvider for type lookup by name #8310

sharwell · 2023-02-22T14:44:50Z

Store WellKnownTypeProvider (from dotnet/roslyn-analyzers) in TagHelperDescriptorProviderContext
Match by type instead of name

…erDescriptorProviderContext

chsienki · 2023-02-23T17:30:22Z

We'll need to run the benchmarks on this to make sure it doesn't regress. Currently the path that we changed name lookup for isn't being hit. So we'll need to incorporate the perf/generator PR on top of this to ensure it doesn't regress in the new scenario.

chsienki · 2023-02-23T19:39:14Z

@sharwell I merged everything together in order to run the benchmarks, and it looks good.

Old:

|           Method |     Mean |   Error |  StdDev |      Gen0 |      Gen1 | Allocated |
|----------------- |---------:|--------:|--------:|----------:|----------:|----------:|
| Cold_Compilation | 391.4 ms | 4.08 ms | 3.82 ms | 6000.0000 | 2000.0000 | 166.92 MB |

|                        Method |     Mean |     Error |    StdDev |    Gen0 |    Gen1 |  Allocated |
|------------------------------ |---------:|----------:|----------:|--------:|--------:|-----------:|
|         Razor_Add_Independent | 5.140 ms | 0.0516 ms | 0.0483 ms | 78.1250 | 31.2500 | 2142.84 KB |
|        Razor_Edit_Independent | 4.143 ms | 0.0417 ms | 0.0370 ms | 85.9375 | 31.2500 |  2186.2 KB |
|      Razor_Remove_Independent | 1.590 ms | 0.0095 ms | 0.0084 ms | 31.2500 | 11.7188 |  818.17 KB |
| Razor_Edit_DependentIgnorable | 2.934 ms | 0.0206 ms | 0.0193 ms | 54.6875 | 15.6250 | 1362.03 KB |
|          Razor_Edit_Dependent | 6.258 ms | 0.1012 ms | 0.0947 ms | 93.7500 | 31.2500 | 2358.26 KB |
|        Razor_Remove_Dependent | 1.542 ms | 0.0308 ms | 0.0329 ms | 31.2500 | 15.6250 |  818.18 KB |


New:

|           Method |     Mean |    Error |   StdDev |   Median |      Gen0 |      Gen1 | Allocated |
|----------------- |---------:|---------:|---------:|---------:|----------:|----------:|----------:|
| Cold_Compilation | 516.2 ms | 10.79 ms | 31.66 ms | 504.8 ms | 5000.0000 | 2000.0000 | 132.29 MB |


|                        Method |     Mean |     Error |    StdDev |   Median |    Gen0 |    Gen1 |  Allocated |
|------------------------------ |---------:|----------:|----------:|---------:|--------:|--------:|-----------:|
|         Razor_Add_Independent | 5.692 ms | 0.1097 ms | 0.0916 ms | 5.718 ms | 46.8750 | 15.6250 | 1405.31 KB |
|        Razor_Edit_Independent | 5.190 ms | 0.1032 ms | 0.3044 ms | 5.109 ms | 54.6875 | 23.4375 | 1434.03 KB |
|      Razor_Remove_Independent | 1.716 ms | 0.0325 ms | 0.0348 ms | 1.713 ms | 15.6250 |  7.8125 |  390.03 KB |
| Razor_Edit_DependentIgnorable | 3.105 ms | 0.0326 ms | 0.0289 ms | 3.096 ms | 39.0625 | 15.6250 | 1023.87 KB |
|          Razor_Edit_Dependent | 7.545 ms | 0.2226 ms | 0.6565 ms | 7.536 ms | 62.5000 | 31.2500 | 1604.64 KB |
|        Razor_Remove_Dependent | 1.724 ms | 0.0329 ms | 0.0308 ms | 1.729 ms | 15.6250 |  3.9063 |  390.04 KB |

Note that the 'old' doesn't include #8297 so the allocations are a little higher, but generally looks like the perf impact is minimal (it was like 10x slower with GetTypeByMetadataName)

333fred · 2023-02-23T18:41:44Z

src/Compiler/Microsoft.CodeAnalysis.Razor/src/ImmutableArrayExtensions.cs

+
+namespace Microsoft.CodeAnalysis.Razor;
+
+internal static class ImmutableArrayExtensions


Please move these to https://github.com/dotnet/razor/blob/main/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/ImmutableArrayExtensions.cs.

➡️ Moving to new location

333fred · 2023-02-23T18:42:12Z

src/Compiler/Microsoft.CodeAnalysis.Razor/src/PublicAPI.Unshipped.txt

@@ -1 +1,2 @@
 #nullable enable
+*REMOVED*~static Microsoft.CodeAnalysis.Razor.TagHelperDescriptorProviderContextExtensions.SetCompilation(this Microsoft.AspNetCore.Razor.Language.TagHelperDescriptorProviderContext context, Microsoft.CodeAnalysis.Compilation compilation) -> void


We can't break the public API yet.

➡️ Restoring the method, marking obsolete, and implementing by creating a new WellKnownTypeProvider and forwarding the call to SetTypeProvider

333fred · 2023-02-23T21:53:45Z

src/Compiler/Microsoft.CodeAnalysis.Razor/src/ComponentTagHelperDescriptorProvider.cs

-        var compilation = context.GetCompilation();
-        if (compilation == null)
+        var typeProvider = context.GetTypeProvider();
+        if (typeProvider == null || !ComponentSymbols.TryCreate(typeProvider, out var symbols))


Feels like it might be cleaner to move the typeProvider == null into TryCreate.

➡️ Added the null check to TryCreate

333fred · 2023-02-23T22:13:53Z

src/Compiler/Microsoft.CodeAnalysis.Razor/src/SymbolExtensions.cs

+        switch (symbol.Kind)
+        {
+            case SymbolKind.Alias:
+                // Aliases are uber private.  They're only visible in the same file that they


I just know this is a Cyrus comment.

333fred · 2023-02-23T22:15:13Z

src/Compiler/Microsoft.CodeAnalysis.Razor/src/SymbolVisibility.cs

+    Public = 0,
+    Internal = 1,
+    Private = 2,
+    Friend = Internal,


We don't deal with VB, this alias isn't required.

➡️ Removing

333fred · 2023-02-23T22:17:39Z

src/Compiler/Microsoft.CodeAnalysis.Razor/src/WellKnownTypeProvider.cs

+/// <summary>
+/// Provides and caches well known types in a compilation.
+/// </summary>
+public class WellKnownTypeProvider


Feels like maybe we should pull this from roslyn-analyzers into a shared package, like we do for pooled objects. I'm somewhat concerned about trying to keep this up to date: razor already has plenty of things copied over that have received significant changes from the original code.

It's certainly possible. I'm not happy with the current API shape so I'd be hoping for a significant rewrite.

Ideally this would be moved to the compiler as part of a source generator helper API, and instead of operating on Compilation it would operate on IAssemblySymbol in a manner than allows symbols from metadata references to be carried forward in an incremental source generator without changing every time the compilation changes.

➡️ Not planning on making any changes here as part of this pull request.

333fred · 2023-02-24T18:37:13Z

I merged everything together in order to run the benchmarks, and it looks good.

@chsienki correct me if I'm reading this wrong, but those benchmarks don't look good? Cold compilation, in particular, looks bad. The minor memory savings don't seem to be paying off with wall-clock time.

sharwell changed the title ~~Store WellKnownTypeProvider (from dotnet/roslyn-analyzers) in TagHelperDescriptorProviderContext~~ Adopt WellKnownTypeProvider for type lookup by name Feb 22, 2023

Store WellKnownTypeProvider (from dotnet/roslyn-analyzers) in TagHelp…

6e78f5a

…erDescriptorProviderContext

sharwell force-pushed the optimize-sg branch from 69dc9c7 to 6e78f5a Compare February 22, 2023 16:19

Match IComponent interface by symbol instead of name

23b7552

sharwell force-pushed the optimize-sg branch from 7b77a7c to 23b7552 Compare February 22, 2023 20:47

sharwell added 2 commits February 22, 2023 18:59

Match by type instead of name in ComponentTagHelperDescriptorProvider

a653a5b

Match by type instead of name in DefaultTagHelperDescriptorFactory

a9ebafd

sharwell force-pushed the optimize-sg branch from 9cdb43d to a653a5b Compare February 23, 2023 00:59

sharwell marked this pull request as ready for review February 23, 2023 15:45

sharwell requested review from a team as code owners February 23, 2023 15:45

333fred reviewed Feb 23, 2023

View reviewed changes

Updates from code review feedback

4e19a68

jaredpar added this to the Backlog milestone Sep 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adopt WellKnownTypeProvider for type lookup by name #8310

Adopt WellKnownTypeProvider for type lookup by name #8310

sharwell commented Feb 22, 2023 •

edited

Loading

chsienki commented Feb 23, 2023

chsienki commented Feb 23, 2023

333fred Feb 23, 2023

sharwell Feb 24, 2023 •

edited

Loading

333fred Feb 23, 2023

sharwell Feb 24, 2023 •

edited

Loading

333fred Feb 23, 2023

sharwell Feb 24, 2023 •

edited

Loading

333fred Feb 23, 2023

333fred Feb 23, 2023

sharwell Feb 24, 2023 •

edited

Loading

333fred Feb 23, 2023

sharwell Feb 24, 2023 •

edited

Loading

333fred commented Feb 24, 2023


		namespace Microsoft.CodeAnalysis.Razor;

		internal static class ImmutableArrayExtensions

		@@ -1 +1,2 @@
		#nullable enable
		REMOVED~static Microsoft.CodeAnalysis.Razor.TagHelperDescriptorProviderContextExtensions.SetCompilation(this Microsoft.AspNetCore.Razor.Language.TagHelperDescriptorProviderContext context, Microsoft.CodeAnalysis.Compilation compilation) -> void

Adopt WellKnownTypeProvider for type lookup by name #8310

Are you sure you want to change the base?

Adopt WellKnownTypeProvider for type lookup by name #8310

Conversation

sharwell commented Feb 22, 2023 • edited Loading

chsienki commented Feb 23, 2023

chsienki commented Feb 23, 2023

333fred Feb 23, 2023

Choose a reason for hiding this comment

sharwell Feb 24, 2023 • edited Loading

Choose a reason for hiding this comment

333fred Feb 23, 2023

Choose a reason for hiding this comment

sharwell Feb 24, 2023 • edited Loading

Choose a reason for hiding this comment

333fred Feb 23, 2023

Choose a reason for hiding this comment

sharwell Feb 24, 2023 • edited Loading

Choose a reason for hiding this comment

333fred Feb 23, 2023

Choose a reason for hiding this comment

333fred Feb 23, 2023

Choose a reason for hiding this comment

sharwell Feb 24, 2023 • edited Loading

Choose a reason for hiding this comment

333fred Feb 23, 2023

Choose a reason for hiding this comment

sharwell Feb 24, 2023 • edited Loading

Choose a reason for hiding this comment

333fred commented Feb 24, 2023

sharwell commented Feb 22, 2023 •

edited

Loading

sharwell Feb 24, 2023 •

edited

Loading

sharwell Feb 24, 2023 •

edited

Loading

sharwell Feb 24, 2023 •

edited

Loading

sharwell Feb 24, 2023 •

edited

Loading

sharwell Feb 24, 2023 •

edited

Loading