Simplify assembly code bases #8410
Merged
+21
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test results on this PR seem to be a bit flaky. Not sure if its related to this PR though, will need to see how other future PRs go I think. Run 1, one integration test failed There is at least one compiler PR that has run integration tests successfully though, so I think things are okay, maybe. |
allisonchou
approved these changes
Mar 10, 2023
ryzngard
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled from #8349
Removal of upper bound will remove most of the maintenance burden.
Shrinking to a single line makes it must easier to identify which assemblies are missing in future.