Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't register cohost types with the Razor project system #9830

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

davidwengier
Copy link
Contributor

@davidwengier davidwengier commented Jan 18, 2024

Part of #9519

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1939874

FYI @333fred

After talking to @DustinCampbell this morning I decided to slightly change tact with cohosting, and not worry about having it be able to co-exist with the current language server. That means this RPS regression is easy to fix just by disconnecting the cohost OpenDocumentGenerator from that system. Yes, that means co-hosting is now slightly worse, but if we move away from co-existence, then it matters a lot less, as we no longer expect it to fully work, it just needs to work enough to let us all get our work done. This PR doesn't change that.

In reality what this change does is that if cohosting is on, and the old server is off, then semantic tokens won't be correct for files that were already open when you stared VS. You have to close and reopen the file. No big deal IMO

@davidwengier davidwengier requested a review from a team as a code owner January 18, 2024 02:54
@davidwengier
Copy link
Contributor Author

davidwengier commented Jan 18, 2024

@davidwengier
Copy link
Contributor Author

Perf DDRITs passed, so I think that means this fixes the issue.

@davidwengier davidwengier merged commit 6bab09c into dotnet:main Jan 18, 2024
12 checks passed
@davidwengier davidwengier deleted the FixMEFLoad branch January 18, 2024 20:42
@ghost ghost added this to the Next milestone Jan 18, 2024
@Cosifne Cosifne modified the milestones: Next, 17.10 P1 Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants