Skip to content

Commit

Permalink
Feedback.
Browse files Browse the repository at this point in the history
  • Loading branch information
333fred committed Dec 10, 2024
1 parent ffb76ca commit ce70a57
Show file tree
Hide file tree
Showing 18 changed files with 60 additions and 60 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -606,12 +606,12 @@
<value>Implementations of this interface are not allowed</value>
</data>
<data name="DoNotUseFileTypesForAnalyzersOrGeneratorsDescription" xml:space="preserve">
<value>Using a 'file' type is not allowed for analyzers, generators, or code fixers.</value>
<value>Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</value>
</data>
<data name="DoNotUseFileTypesForAnalyzersOrGeneratorsMessage" xml:space="preserve">
<value>Type '{0}' should not be marked with 'file'</value>
</data>
<data name="DoNotUseFileTypesForAnalyzersOrGeneratorsTitle" xml:space="preserve">
<value>Do not use file types for analyzers, generators, and code fixers</value>
<value>Do not use file types for implementing analyzers, generators, and code fixers</value>
</data>
</root>
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public sealed class DoNotUseFileTypesForAnalyzersOrGenerators : DiagnosticAnalyz
isEnabledByDefault: true,
description: CreateLocalizableResourceString(nameof(DoNotUseFileTypesForAnalyzersOrGeneratorsDescription)));

public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } = ImmutableArray.Create(Rule);

public override void Initialize(AnalysisContext context)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsDescription">
<source>Using a 'file' type is not allowed for analyzers, generators, or code fixers.</source>
<target state="new">Using a 'file' type is not allowed for analyzers, generators, or code fixers.</target>
<source>Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</source>
<target state="new">Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsMessage">
Expand All @@ -183,8 +183,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsTitle">
<source>Do not use file types for analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for analyzers, generators, and code fixers</target>
<source>Do not use file types for implementing analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for implementing analyzers, generators, and code fixers</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseReservedDiagnosticIdDescription">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsDescription">
<source>Using a 'file' type is not allowed for analyzers, generators, or code fixers.</source>
<target state="new">Using a 'file' type is not allowed for analyzers, generators, or code fixers.</target>
<source>Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</source>
<target state="new">Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsMessage">
Expand All @@ -183,8 +183,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsTitle">
<source>Do not use file types for analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for analyzers, generators, and code fixers</target>
<source>Do not use file types for implementing analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for implementing analyzers, generators, and code fixers</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseReservedDiagnosticIdDescription">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsDescription">
<source>Using a 'file' type is not allowed for analyzers, generators, or code fixers.</source>
<target state="new">Using a 'file' type is not allowed for analyzers, generators, or code fixers.</target>
<source>Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</source>
<target state="new">Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsMessage">
Expand All @@ -183,8 +183,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsTitle">
<source>Do not use file types for analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for analyzers, generators, and code fixers</target>
<source>Do not use file types for implementing analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for implementing analyzers, generators, and code fixers</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseReservedDiagnosticIdDescription">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsDescription">
<source>Using a 'file' type is not allowed for analyzers, generators, or code fixers.</source>
<target state="new">Using a 'file' type is not allowed for analyzers, generators, or code fixers.</target>
<source>Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</source>
<target state="new">Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsMessage">
Expand All @@ -183,8 +183,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsTitle">
<source>Do not use file types for analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for analyzers, generators, and code fixers</target>
<source>Do not use file types for implementing analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for implementing analyzers, generators, and code fixers</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseReservedDiagnosticIdDescription">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsDescription">
<source>Using a 'file' type is not allowed for analyzers, generators, or code fixers.</source>
<target state="new">Using a 'file' type is not allowed for analyzers, generators, or code fixers.</target>
<source>Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</source>
<target state="new">Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsMessage">
Expand All @@ -183,8 +183,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsTitle">
<source>Do not use file types for analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for analyzers, generators, and code fixers</target>
<source>Do not use file types for implementing analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for implementing analyzers, generators, and code fixers</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseReservedDiagnosticIdDescription">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsDescription">
<source>Using a 'file' type is not allowed for analyzers, generators, or code fixers.</source>
<target state="new">Using a 'file' type is not allowed for analyzers, generators, or code fixers.</target>
<source>Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</source>
<target state="new">Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsMessage">
Expand All @@ -183,8 +183,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsTitle">
<source>Do not use file types for analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for analyzers, generators, and code fixers</target>
<source>Do not use file types for implementing analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for implementing analyzers, generators, and code fixers</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseReservedDiagnosticIdDescription">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsDescription">
<source>Using a 'file' type is not allowed for analyzers, generators, or code fixers.</source>
<target state="new">Using a 'file' type is not allowed for analyzers, generators, or code fixers.</target>
<source>Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</source>
<target state="new">Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsMessage">
Expand All @@ -183,8 +183,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsTitle">
<source>Do not use file types for analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for analyzers, generators, and code fixers</target>
<source>Do not use file types for implementing analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for implementing analyzers, generators, and code fixers</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseReservedDiagnosticIdDescription">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsDescription">
<source>Using a 'file' type is not allowed for analyzers, generators, or code fixers.</source>
<target state="new">Using a 'file' type is not allowed for analyzers, generators, or code fixers.</target>
<source>Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</source>
<target state="new">Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsMessage">
Expand All @@ -183,8 +183,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsTitle">
<source>Do not use file types for analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for analyzers, generators, and code fixers</target>
<source>Do not use file types for implementing analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for implementing analyzers, generators, and code fixers</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseReservedDiagnosticIdDescription">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsDescription">
<source>Using a 'file' type is not allowed for analyzers, generators, or code fixers.</source>
<target state="new">Using a 'file' type is not allowed for analyzers, generators, or code fixers.</target>
<source>Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</source>
<target state="new">Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsMessage">
Expand All @@ -183,8 +183,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsTitle">
<source>Do not use file types for analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for analyzers, generators, and code fixers</target>
<source>Do not use file types for implementing analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for implementing analyzers, generators, and code fixers</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseReservedDiagnosticIdDescription">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsDescription">
<source>Using a 'file' type is not allowed for analyzers, generators, or code fixers.</source>
<target state="new">Using a 'file' type is not allowed for analyzers, generators, or code fixers.</target>
<source>Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</source>
<target state="new">Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsMessage">
Expand All @@ -183,8 +183,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsTitle">
<source>Do not use file types for analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for analyzers, generators, and code fixers</target>
<source>Do not use file types for implementing analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for implementing analyzers, generators, and code fixers</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseReservedDiagnosticIdDescription">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsDescription">
<source>Using a 'file' type is not allowed for analyzers, generators, or code fixers.</source>
<target state="new">Using a 'file' type is not allowed for analyzers, generators, or code fixers.</target>
<source>Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</source>
<target state="new">Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsMessage">
Expand All @@ -183,8 +183,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsTitle">
<source>Do not use file types for analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for analyzers, generators, and code fixers</target>
<source>Do not use file types for implementing analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for implementing analyzers, generators, and code fixers</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseReservedDiagnosticIdDescription">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsDescription">
<source>Using a 'file' type is not allowed for analyzers, generators, or code fixers.</source>
<target state="new">Using a 'file' type is not allowed for analyzers, generators, or code fixers.</target>
<source>Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</source>
<target state="new">Using a 'file' type is not allowed for implementing analyzers, generators, or code fixers. This can break analyzer loading on some platforms.</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsMessage">
Expand All @@ -183,8 +183,8 @@
<note />
</trans-unit>
<trans-unit id="DoNotUseFileTypesForAnalyzersOrGeneratorsTitle">
<source>Do not use file types for analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for analyzers, generators, and code fixers</target>
<source>Do not use file types for implementing analyzers, generators, and code fixers</source>
<target state="new">Do not use file types for implementing analyzers, generators, and code fixers</target>
<note />
</trans-unit>
<trans-unit id="DoNotUseReservedDiagnosticIdDescription">
Expand Down
Loading

0 comments on commit ce70a57

Please sign in to comment.