Skip to content

Commit

Permalink
Test failure - SendAsync_RequestVersion20_ResponseVersion20 (#112232)
Browse files Browse the repository at this point in the history
* Change server to httpbin
* Update Http2NoPushHost and add Http2NoPushGetUris for improved testing
  • Loading branch information
rokonec authored Feb 7, 2025
1 parent 0f0f8ce commit 7324dd1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion src/libraries/Common/tests/System/Net/Configuration.Http.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public static partial class Http

// This server doesn't use HTTP/2 server push (push promise) feature. Some HttpClient implementations
// don't support servers that use push right now.
public static string Http2NoPushHost => GetValue("DOTNET_TEST_HTTP2NOPUSHHOST", "www.microsoft.com");
public static string Http2NoPushHost => GetValue("DOTNET_TEST_HTTP2NOPUSHHOST", "httpbin.org");

// Domain server environment.
public static string DomainJoinedHttpHost => GetValue("DOTNET_TEST_DOMAINJOINED_HTTPHOST");
Expand Down Expand Up @@ -106,6 +106,7 @@ public static Uri[] GetEchoServerList()

public static readonly object[][] Http2Servers = { new object[] { new Uri("https://" + Http2Host) } };
public static readonly object[][] Http2NoPushServers = { new object[] { new Uri("https://" + Http2NoPushHost) } };
public static readonly object[][] Http2NoPushGetUris = { new object[] { new Uri("https://" + Http2NoPushHost + "/get") } };

public static readonly RemoteServer RemoteHttp11Server = new RemoteServer(new Uri("http://" + Host + "/"), HttpVersion.Version11);
public static readonly RemoteServer RemoteSecureHttp11Server = new RemoteServer(new Uri("https://" + SecureHost + "/"), HttpVersion.Version11);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public sealed class HttpClientHandler_RemoteServerTest : HttpClientHandlerTestBa

public static readonly object[][] Http2Servers = Configuration.Http.Http2Servers;
public static readonly object[][] Http2NoPushServers = Configuration.Http.Http2NoPushServers;
public static readonly object[][] Http2NoPushGetUris = Configuration.Http.Http2NoPushGetUris;

// Standard HTTP methods defined in RFC7231: http://tools.ietf.org/html/rfc7231#section-4.3
// "GET", "HEAD", "POST", "PUT", "DELETE", "OPTIONS", "TRACE"
Expand Down Expand Up @@ -1365,7 +1366,7 @@ public async Task SendAsync_RequestVersion20_ResponseVersion20IfHttp2Supported(U
}

[OuterLoop("Uses external servers")]
[ConditionalTheory(nameof(IsWindows10Version1607OrGreater)), MemberData(nameof(Http2NoPushServers))]
[ConditionalTheory(nameof(IsWindows10Version1607OrGreater)), MemberData(nameof(Http2NoPushGetUris))]
public async Task SendAsync_RequestVersion20_ResponseVersion20(Uri server)
{
// Sync API supported only up to HTTP/1.1
Expand Down

0 comments on commit 7324dd1

Please sign in to comment.