Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT] Add sampling profiler #108083

Closed
wants to merge 1 commit into from

Conversation

filipnavara
Copy link
Member

Presumably this is pretty useless since we don't do the rundown to get readable method names... but since I already have it laying around, anyone can think of a use for this?

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 20, 2024
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky
Copy link
Member

@LakshanF do you think we'd be able to implement the rest?

If there is a rundown for this, we do have names of methods available in stack trace metadata. If the rundown can run managed code, we could get it there. Maybe. Depending on what actually involves the rundown.

@filipnavara
Copy link
Member Author

I only tried to run it with dotnet-trace and conversion to Speedscope format, which was quite useless, since you could see the stack traces but instead of method names there was just "?!?". I wonder if PerfView could perhaps show the addresses or correlate that to image base addresses. That would be already good enough for tools that can perform native symbolication (eg. Sentry).

Stack trace metadata sound like an interesting thing to try...

@LakshanF
Copy link
Contributor

LakshanF commented Oct 1, 2024

There is a work item in the diagnostic repo to lookup type information for native AOT GCDump, which could be expanded to include method information as well.

Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants