Change assembler to clang in android MonoAOT #110393
Conversation
jkurdek
requested review from
akoeplinger,
steveisok and
vitek-karas
as code owners
|
Tagging subscribers to this area: @akoeplinger, @matouskozak |
|
/azp run runtime-android, runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-android, runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| @@ -141,19 +149,6 @@ | |||
| <AndroidLibraryMinApiLevel Condition="'$(AndroidLibraryMinApiLevel)' == ''">21</AndroidLibraryMinApiLevel> | |||
| </PropertyGroup> | |||
|
|
|||
| <NdkToolFinderTask | |||
There was a problem hiding this comment.
Did you happen to test library mode with this change?
There was a problem hiding this comment.
We had an offline discussion with @steveisok about this. We agree that this should be handled as a follow up: #110757
|
Android fails are unrelated :) |
| <PropertyGroup> | ||
| <_Triple Condition="'$(TargetArchitecture)' == 'arm'">armv7-linux-gnueabi</_Triple> | ||
| <_Triple Condition="'$(TargetArchitecture)' == 'arm64'">aarch64-linux-android</_Triple> | ||
| <_Triple Condition="'$(TargetArchitecture)' == 'x86'">i686-linux-android</_Triple> | ||
| <_Triple Condition="'$(TargetArchitecture)' == 'x64'">x86_64-linux-android</_Triple> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <_LdName>clang</_LdName> | ||
| <_LdOptions>-fuse-ld=lld</_LdOptions> | ||
| <_AsName>clang</_AsName> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
Can we extract these settings to a common .props file so that we don't specify them in the AndroidSampleApp again?
| @@ -141,19 +149,6 @@ | |||
| <AndroidLibraryMinApiLevel Condition="'$(AndroidLibraryMinApiLevel)' == ''">21</AndroidLibraryMinApiLevel> | |||
| </PropertyGroup> | |||
|
|
|||
| <NdkToolFinderTask | |||
|
When testing, did we run |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms, runtime-android, runtime-androidemulator |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/ba-g test failures unrelated, android lines pass |
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12395728413 |
Android NDK 27 does not ship with an assembler. The recommendation is to use clang. This PR makes MonoAOT compiler use clang assembler when building android.
Related PR bumping version of NDK to 27: dotnet/dotnet-buildtools-prereqs-docker#1278
Changes were verified here: #110196