Skip to content

Fix implementation of IFindReferenceTargetsCallback::FoundTrackerTarget #115921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/debug/daccess/request.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4440,7 +4440,7 @@ HRESULT ClrDataAccess::DACTryGetComWrappersObjectFromCCW(CLRDATA_ADDRESS ccwPtr,

holder = (MOWHOLDERREF)ObjectFromHandle(handle);

*objRef = holder->_wrappedObject;
*objRef = holder->WrappedObject;

return S_OK;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,13 +230,20 @@ private static unsafe int IFindReferenceTargetsCallback_FoundTrackerTarget(IntPt
return HResults.E_INVALIDARG;
}

if (TryGetObject(referenceTrackerTarget, out object? foundObject))
if (!TryGetObject(referenceTrackerTarget, out object? targetObject))
{
// Notify the runtime a reference path was found.
return TrackerObjectManager.AddReferencePath(s_currentRootObjectHandle.Target, foundObject) ? HResults.S_OK : HResults.S_FALSE;
return HResults.S_FALSE;
}

return HResults.S_OK;
object sourceObject = s_currentRootObjectHandle.Target!;

if (sourceObject == targetObject)
{
return HResults.S_FALSE;
}

// Notify the runtime a reference path was found.
return TrackerObjectManager.AddReferencePath(sourceObject, targetObject) ? HResults.S_OK : HResults.S_FALSE;
}

internal struct ReferenceTargetsVftbl
Expand Down
1 change: 1 addition & 0 deletions src/coreclr/vm/corelib.h
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,7 @@ DEFINE_FIELD(COMWRAPPERS, NAITVE_OBJECT_WRAPPER_TABLE, s_nativeObjectWrapperTabl
DEFINE_FIELD(COMWRAPPERS, ALL_MANAGED_OBJECT_WRAPPER_TABLE, s_allManagedObjectWrapperTable)

DEFINE_CLASS_U(Interop, ComWrappers+ManagedObjectWrapperHolder, ManagedObjectWrapperHolderObject)
DEFINE_FIELD_U(_wrappedObject, ManagedObjectWrapperHolderObject, WrappedObject)
DEFINE_FIELD_U(_wrapper, ManagedObjectWrapperHolderObject, ManagedObjectWrapper)
DEFINE_CLASS_U(Interop, ComWrappers+NativeObjectWrapper, NativeObjectWrapperObject)
DEFINE_FIELD_U(_comWrappers, NativeObjectWrapperObject, _comWrappers)
Expand Down
17 changes: 12 additions & 5 deletions src/coreclr/vm/interoplibinterface_comwrappers.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -453,16 +453,23 @@ namespace InteropLibImports
CONTRACTL_END;

// Get the external object's managed wrapper
::OBJECTHANDLE srcHandle = static_cast<::OBJECTHANDLE>(targetHandle);
::OBJECTHANDLE srcHandle = static_cast<::OBJECTHANDLE>(sourceHandle);
OBJECTREF source = ObjectFromHandle(srcHandle);

// Get the target of the external object's reference.
::OBJECTHANDLE tgtHandle = static_cast<::OBJECTHANDLE>(targetHandle);
OBJECTREF target = ObjectFromHandle(tgtHandle );
MOWHOLDERREF holder = (MOWHOLDERREF)ObjectFromHandle(tgtHandle);

// Return if the target has been collected or these are the same object.
if (target == NULL
|| source->PassiveGetSyncBlock() == target->PassiveGetSyncBlock())
// Return if the holder has been collected
if (holder == NULL)
{
return S_FALSE;
}

OBJECTREF target = holder->WrappedObject;

// Return if these are the same object.
if (source == target)
{
return S_FALSE;
}
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/vm/interoplibinterface_comwrappers.h
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ class ManagedObjectWrapperHolderObject : public Object
friend class ClrDataAccess;
private:
OBJECTREF _releaser;
OBJECTREF _wrappedObject;
public:
OBJECTREF WrappedObject;
DPTR(InteropLib::ABI::ManagedObjectWrapperLayout) ManagedObjectWrapper;
};

Expand Down
Loading