-
Notifications
You must be signed in to change notification settings - Fork 5k
[browser][WBT] EventPipe - end to end test #115945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds end-to-end tests verifying EventPipe functionality for CPU samples, GC heap dumps, and metrics in a Blazor WebAssembly test app. Key changes include:
- Introducing a runtime configuration for browser with host properties.
- Adding a conditional PackageReference and a file upload endpoint in DevServerStartup.
- Implementing new EventPipe diagnostics tests with updated timeout and validation options.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
App/BlazorBasicTestApp.runtimeconfig.json | Added runtime configuration for browser host properties. |
App/BlazorBasicTestApp.csproj | Updated PackageReference with a condition for DEVSERVER. |
host/DevServer/DevServerStartup.cs | Added file upload endpoint to facilitate test trace uploads. |
Wasm.Build.Tests.csproj | Added dependency on Microsoft.Diagnostics.Tracing.TraceEvent. |
Wasm.Build.Tests/Templates/WasmTemplateTestsBase.cs | Updated timeout logic in WaitForExitMessageAsync. |
Wasm.Build.Tests/BrowserStructures/RunOptions.cs | Introduced TimeoutSeconds property with default value. |
Wasm.Build.Tests/Blazor/EventPipeDiagnosticsTests.cs | Added tests for CPU samples, metrics, and GC heap dump validations. |
Wasm.Build.Tests/Blazor/BlazorRunOptions.cs | Propagated TimeoutSeconds to the run options. |
diagnostics/diagnostics-js.ts | Added a runtime check to prevent multiple diagnostic clients. |
eng/testing/scenarios/BuildWasmAppsJobsList.txt | Updated job list to include EventPipe diagnostics tests. |
src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTestsBase.cs
Outdated
Show resolved
Hide resolved
akoeplinger
approved these changes
May 28, 2025
maraf
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115930