Record exception in HttpClient native instrumentation #115959
Conversation
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/ncl |
|
Failures in CI look unrelated. |
| if (exception is not null) | ||
| { | ||
| // Records the exception as per https://github.com/open-telemetry/opentelemetry-specification/blob/v1.45.0/specification/trace/exceptions.md | ||
| activity.AddException(exception); |
There was a problem hiding this comment.
Actually one thought: This call will record the exception event with a timestamp slightly after the Activity end time. I'm not sure if this will cause any trouble on the monitoring side, but we could avoid the issue by passing timestamp: activity.StartTimeUtc + activity.Duration here.
There was a problem hiding this comment.
I am not sure to understand this point. How the exception event can have a timestamp after the activity end timestamp?
The activity is stopped later l221:
There was a problem hiding this comment.
There is a SetEndTime() call at the top of the finally block:
activity.Stop() will not update value of Duration value if it has been set manually earlier by calling SetEndTime(). (Note that there is no EndTime property SetEndTime() assigns the Duration.)
There was a problem hiding this comment.
Good catch! I missed that. I applied the suggestion and added a comment. Please let me know if it's fine for you.
Fixes #108050.