Skip to content

Fix RISC-V JIT build #117553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

Fix RISC-V JIT build #117553

merged 1 commit into from
Jul 14, 2025

Conversation

amanasifkhalid
Copy link
Member

Fixes #117550.

@dotnet/jit-contrib PTAL.

@Copilot Copilot AI review requested due to automatic review settings July 11, 2025 18:13
@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 11, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a build warning on the RISC-V JIT backend by ensuring the address-offset comparison uses matching types.

  • Casts the offset to UNATIVE_OFFSET before comparing to emitDataSize()
  • Preserves existing logic and assertions

@risc-vv
Copy link

risc-vv commented Jul 11, 2025

@dotnet/samsung Could you please take a look? These changes may be related to riscv64.

Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@risc-vv
Copy link

risc-vv commented Jul 11, 2025

RISC-V Release-CLR-VF2: 9083 / 9113 (99.67%)
=======================
      passed: 9083
      failed: 2
     skipped: 597
      killed: 28
------------------------
 TOTAL tests: 9710
VIRTUAL time: 11h 13min 21s 912ms
   REAL time: 45min 40s 887ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-QEMU: 284027 / 285104 (99.62%)
=======================
      passed: 284027
      failed: 1072
     skipped: 39
      killed: 5
------------------------
 TOTAL tests: 285143
VIRTUAL time: 30h 42min 55s 8ms
   REAL time: 1h 12min 11s 902ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-CLR-QEMU: 9082 / 9112 (99.67%)
=======================
      passed: 9082
      failed: 2
     skipped: 597
      killed: 28
------------------------
 TOTAL tests: 9709
VIRTUAL time: 37h 28min 17s 967ms
   REAL time: 38min 16s 886ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-VF2: 308188 / 309925 (99.44%)
=======================
      passed: 308188
      failed: 1729
     skipped: 39
      killed: 8
------------------------
 TOTAL tests: 309964
VIRTUAL time: 21h 24min 56s 333ms
   REAL time: 2h 18min 20s 14ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: b795a84ce65bba25de0f4cb51a2af1a121c9e76e
CI: d6c9c1ab3a7411819463edc05ded301e89ba586a
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

@jakobbotsch jakobbotsch merged commit 3add8d2 into dotnet:main Jul 14, 2025
112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RISC-V JIT build failing due to signed/unsigned comparison
3 participants