-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Add support for some more simd folding to improve the new IndexOf and related helpers #117572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,071
−650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannergooding
commented
Jul 12, 2025
tannergooding
commented
Jul 12, 2025
a039ab6
to
3d662c4
Compare
tannergooding
commented
Jul 12, 2025
CC. @dotnet/jit-contrib Fixes some codegen issues that @EgorBo saw. Going to have a follow up PR that better improves the Arm64 handling by ensuring that |
Open
3 tasks
EgorBo
approved these changes
Jul 14, 2025
/azp run Fuzzlyn |
Azure Pipelines successfully started running 1 pipeline(s). |
Fuzzlyn issue is #117605 |
/ba-g unrelated android timeouts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles cases like
Vector128.IndexOfWhereAllBitsSet(Vector128.Equals(x, y))
and ensures we get more optimal codegen.This mostly stems from ensuring that
Compare(mask, AllBitsSet)
andCompare(mask, Zero)
are handled. However, it also found some cases where we weren't foldingTrailingZeroCount
,ReverseElementBits
, orPopCount
which are used by the new helpers and so ensures those are handled as well.