[PERF][iOS] Simplify iOS performance measurement scripts #120531
Merged
+102
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clearer naming of codegen/runtime variants - remove non strip symbols variants
matouskozak
added
tenet-performance
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies and standardizes iOS performance measurement scripts by refactoring naming conventions and removing duplicate measurements with different symbol stripping settings.
Key Changes
- Refactors artifact and display names to be more consistent and descriptive
- Removes redundant build configurations that only differed by the
STRIP_DEBUG_SYMBOLSsetting - Standardizes comment casing throughout build scripts
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/mono/sample/iOS/Makefile | Removes unused HYBRID_GLOBALIZATION parameter and related build configuration |
| eng/pipelines/performance/templates/perf-ios-scenarios-build-jobs.yml | Removes hybridGlobalization parameter from build template |
| eng/pipelines/performance/templates/build-perf-sample-apps.yml | Major refactoring of iOS build configurations, removing duplicate builds and standardizing naming |
|
Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival |
Co-authored-by: Copilot <[email protected]>
kotlarmilos
approved these changes
Oct 8, 2025
LoopedBard3
approved these changes
Oct 8, 2025
|
The diagnostic failure is unrelated and is failing on main as well https://dev.azure.com/dnceng-public/public/_build/results?buildId=1168122&view=logs&j=99a40162-d9e8-55f4-b01d-4be4f1208c7a&t=a2060ea1-f616-5d11-98a7-dfd0dac99e77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated dotnet/performance PR: dotnet/performance#5007
Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2810833