Skip to content

nested FailFast #121306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 4, 2025
Merged

nested FailFast #121306

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9736509
gc hole + nested FailFast
pavelsavara Nov 3, 2025
95e4ce1
better comment
pavelsavara Nov 3, 2025
7d2f47c
feedback
pavelsavara Nov 3, 2025
226952a
Merge branch 'main' into fail_fast
pavelsavara Nov 4, 2025
7a19302
feedback
pavelsavara Nov 4, 2025
00124b3
Update src/coreclr/classlibnative/bcltype/system.cpp
pavelsavara Nov 4, 2025
89bb278
Update src/coreclr/classlibnative/bcltype/system.cpp
pavelsavara Nov 4, 2025
4a42e4e
Update src/coreclr/classlibnative/bcltype/system.cpp
jkotas Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/coreclr/classlibnative/bcltype/system.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ static StackWalkAction FindFailFastCallerCallback(CrawlFrame* frame, VOID* data)
return SWA_ABORT;
}

static thread_local int8_t alreadyFailing = 0;

extern "C" void QCALLTYPE Environment_FailFast(QCall::StackCrawlMarkHandle mark, PCWSTR message, QCall::ObjectHandleOnStack exception, PCWSTR errorSource)
{
QCALL_CONTRACT;
Expand All @@ -143,7 +145,14 @@ extern "C" void QCALLTYPE Environment_FailFast(QCall::StackCrawlMarkHandle mark,

LPCWSTR argExceptionString = NULL;
StackSString msg;
if (exception.Get() != NULL)
// Because Environment_FailFast should kill the process, any subsequent calls are likely nested call from managed while formatting the exception message or the stack trace.
// Only collect exception string if this is the first attempt to fail fast on this thread.
alreadyFailing++;
if (alreadyFailing != 1)
{
argExceptionString = W("Environment.FailFast called recursively.");
}
else if (exception.Get() != NULL)
{
GetExceptionMessage(exception.Get(), msg);
argExceptionString = msg.GetUnicode();
Expand Down
Loading