[release/6.0] Provide locations for src-gen diagnostic output #61614
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsBackport of #61430 to release/6.0 Customer ImpactProvides locations for diagnostics emitted by the JSON source generator to allow users to navigate to warning/error cites in VS and view them in the command line. Lack of this support was reported by a customer in #60314. RegressionNot a regression but regarded as an important enhancement for users of the source generator. TestingThere are tests for the locations of the emitted diagnostics included. RiskLow, there are defensive checks to insure we don't leak exceptions while trying to fetch the locations from Roslyn metadata.
|
layomia
added
Servicing-approved
|
Approved by Tactics via email. |
|
@layomia This appears to have broken the official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1472248&view=logs&j=2eb9059d-e9c2-5d92-005c-adb7433ab8cb&t=be5a3035-b903-5888-b13b-315ebe2ddccf&l=1753 Does that look familiar at all? |
|
Yes it should be fixed by: #61697 |
ghost
locked as resolved and limited conversation to collaborators
Backport of #61430 to release/6.0
Customer Impact
Provides locations for diagnostics emitted by the JSON source generator to allow users to navigate to warning/error sites in VS and view them in the command line. Lack of this support was reported in #60314.
Regression
Not a regression but regarded as an important enhancement for users of the source generator.
Testing
There are tests for the locations of the emitted diagnostics included.
Risk
Low, there are defensive checks to insure we don't leak exceptions while trying to fetch the locations from Roslyn metadata.