Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] Remove ValueTask interop test placeholders #94560

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[browser] Remove ValueTask interop test placeholders #94560

merged 1 commit into from
Nov 10, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented Nov 9, 2023

Closes #61368

@maraf maraf added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Nov 9, 2023
@maraf maraf added this to the 9.0.0 milestone Nov 9, 2023
@maraf maraf self-assigned this Nov 9, 2023
@ghost
Copy link

ghost commented Nov 9, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #61368

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

This was referenced Nov 9, 2023
Open
Open
@maraf
Copy link
Member Author

maraf commented Nov 10, 2023

Failures are dotnet/dnceng#451 and #93206

@maraf maraf merged commit c07cb44 into dotnet:main Nov 10, 2023
116 of 119 checks passed
@maraf maraf deleted the BrowserRemoveValueTaskInteropTestPlaceholders branch November 10, 2023 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[wasm] Implement ValueTask marshaling
2 participants
@maraf @pavelsavara