Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] [browser] Fix debugger support #98494

Merged
merged 13 commits into from
Jul 26, 2024

Conversation

maraf
Copy link
Member

@maraf maraf commented Feb 15, 2024

Migration of #97213 (also #100675 and partially #104361)
Fixes #102307

Customer Impact

Fixes several customer reported issues regarding custom configuration name and ability to debug application.
Regression from unification of Blazor SDK and former runtime Wasm SDK from .NET 8 cycle.

Testing

Automated tests for all scenarios (build, publish, implicit and explicit values)

Risk

Low

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Feb 15, 2024
@maraf maraf added this to the 8.0.x milestone Feb 15, 2024
@maraf maraf self-assigned this Feb 15, 2024
@ghost
Copy link

ghost commented Feb 15, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Migration of #97213

TBD

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono, os-browser

Milestone: 8.0.x

@maraf

This comment was marked as resolved.

@maraf

This comment was marked as resolved.

@maraf
Copy link
Member Author

maraf commented Mar 4, 2024

/azp run runtime

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Member

Friendly reminder that Monday March 11th is the Code Complete date for the April Release. If you want this change to be included in that release, please make sure to mark it as ready for review, get a code review sign-off, get a green CI (or confirm the issues are unrelated), and send an email to Tactics requesting approval. Otherwise, it will have to wait until the May Release. @maraf

Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2024
@maraf maraf reopened this Jun 14, 2024
@maraf maraf closed this Jun 20, 2024
@maraf maraf reopened this Jun 20, 2024
@carlossanlop
Copy link
Member

@maraf friendly reminder that code complete for the August Release is July 15th. If you want this fix to be included in that release, please merge this PR before that date.

@carlossanlop
Copy link
Member

Friendly reminder that Monday July 15th is Code Complete day, that's the deadline to get this included in the August Release.

@maraf
Copy link
Member Author

maraf commented Jul 15, 2024

/azp run runtime

@maraf maraf marked this pull request as ready for review July 15, 2024 12:15
@maraf maraf added the Servicing-consider Issue for next servicing release review label Jul 15, 2024
@maraf maraf added this to the 8.0.x milestone Jul 15, 2024
@maraf maraf requested a review from akoeplinger July 15, 2024 12:20
@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 23, 2024
@jeffschwMSFT jeffschwMSFT modified the milestones: 8.0.x, 8.0.9 Jul 23, 2024
@maraf maraf merged commit c9c0bf6 into dotnet:release/8.0-staging Jul 26, 2024
37 of 40 checks passed
@maraf maraf deleted the BrowserDebuggerSupport80 branch July 26, 2024 12:36
@maraf
Copy link
Member Author

maraf commented Jul 26, 2024

@guardrex Since 8.0.9 the original behavior from .NET 7 will be restored, can you please update the docs for .NET 8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants