Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design doc for Roslyn Attribute for ByRefLike generics #99916

Merged

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Mar 18, 2024

Constributes to #65112

Discussion at #99788

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices
See info in area-owners.md if you want to be subscribed.

@AaronRobinsonMSFT
Copy link
Member Author

/cc @lambdageek @fanyang-mono

@jkotas
Copy link
Member

jkotas commented Mar 18, 2024

Do we need this given #99788 (comment) ?

@AaronRobinsonMSFT
Copy link
Member Author

AaronRobinsonMSFT commented Mar 19, 2024

Do we need this given #99788 (comment) ?

Not the code, no. I am going to keep the updated spec though. I will mark it as a future option and capture some of the details discussed.

@AaronRobinsonMSFT AaronRobinsonMSFT changed the title Attribute for ByRefLike generics Update design doc for Roslyn Attribute for ByRefLike generics Mar 19, 2024
@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 06e3fe4 into dotnet:main Mar 19, 2024
12 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the byref_generic_unsafe branch March 19, 2024 17:31
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants