-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update design doc for Roslyn Attribute for ByRefLike generics #99916
Merged
AaronRobinsonMSFT
merged 1 commit into
dotnet:main
from
AaronRobinsonMSFT:byref_generic_unsafe
Mar 19, 2024
Merged
Update design doc for Roslyn Attribute for ByRefLike generics #99916
AaronRobinsonMSFT
merged 1 commit into
dotnet:main
from
AaronRobinsonMSFT:byref_generic_unsafe
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRobinsonMSFT
requested review from
jaredpar,
stephentoub,
jkotas and
AlekseyTs
March 18, 2024 17:07
Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices |
13 tasks
AlekseyTs
approved these changes
Mar 18, 2024
jkotas
reviewed
Mar 18, 2024
jkotas
reviewed
Mar 18, 2024
src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Mar 18, 2024
3 tasks
Do we need this given #99788 (comment) ? |
Not the code, no. I am going to keep the updated spec though. I will mark it as a future option and capture some of the details discussed. |
AaronRobinsonMSFT
force-pushed
the
byref_generic_unsafe
branch
from
March 19, 2024 00:34
ffba6ff
to
bc3e51c
Compare
AaronRobinsonMSFT
changed the title
Attribute for ByRefLike generics
Update design doc for Roslyn Attribute for ByRefLike generics
Mar 19, 2024
fanyang-mono
approved these changes
Mar 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constributes to #65112
Discussion at #99788