[NativeAOT-LLVM] Don't use mmap in the frozen object manager and enable writeable data
#2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is going upstream.
SingleAccretion
force-pushed
the
EETypes
branch
from
e61d726 to
7fd6188
Compare
|
@dotnet/nativeaot-llvm |
jkotas
added
the
area-NativeAOT-LLVM
jkotas
reviewed
Jan 23, 2024
| { | ||
| if (node is StackTraceMethodMappingNode) | ||
| { | ||
| // Stack trace metadata uses relative pointers, but is currently unused. |
There was a problem hiding this comment.
Do we have an issue about deleting it or making it work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2476.
Fixes #2477.
The latter part part of this change will be upstreamed.