ResolvePackageReferences: PackageDependenciesDesignTime inherits transitive package DiagnosticLevel #42546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sitive package DiagnosticLevel
ghost
added
zivkan
commented
Aug 7, 2024
zivkan
commented
Aug 7, 2024
nagilson
reviewed
Aug 8, 2024
nagilson
reviewed
Aug 8, 2024
nagilson
approved these changes
Aug 12, 2024
|
Triage: @zivkan you are clear to merge whenever but please file an issue and assign to yourself to do the follow up PR that you outlined. |
|
/backport to release/9.0.1xx |
|
Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/10745630791 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scenario is described here: NuGet/Home#13636
TL;DR in Visual Studio, Solution Explorer's dependencies node should put a warning icon on all the "parent" packages when a transitive package has a warning. While the transitive package icon overlays happens within NuGet's VS code the dotnet/project-system handles the top level package references, via ResolvePackageAssets output items.