Skip to content

Conversation

zivkan
Copy link
Member

@zivkan zivkan commented Aug 6, 2024

The scenario is described here: NuGet/Home#13636

TL;DR in Visual Studio, Solution Explorer's dependencies node should put a warning icon on all the "parent" packages when a transitive package has a warning. While the transitive package icon overlays happens within NuGet's VS code the dotnet/project-system handles the top level package references, via ResolvePackageAssets output items.

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Aug 6, 2024
@marcpopMSFT marcpopMSFT requested a review from nagilson August 6, 2024 20:43
Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good for the most part, but I do have one question/concern for the code. PTAL and let me know your thoughts.

@nagilson nagilson requested a review from a team August 8, 2024 19:12
@zivkan zivkan requested a review from nagilson August 9, 2024 23:28
Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me, thank you :)

@marcpopMSFT
Copy link
Member

Triage: @zivkan you are clear to merge whenever but please file an issue and assign to yourself to do the follow up PR that you outlined.

@zivkan zivkan merged commit e43f370 into dotnet:main Aug 14, 2024
@zivkan zivkan deleted the transitive-diagnostic-level branch August 14, 2024 22:07
@zivkan
Copy link
Member Author

zivkan commented Sep 6, 2024

/backport to release/9.0.1xx

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/10745630791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants