upgraded logging for #595 log url when connection is closed #44953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Containers
|
Previously there was already an url mentioned, so I believe this issue was already resolved before I started. That being said, the error message didn't differentiate between upload and fetch failures which I remedied: |
SimaTian
force-pushed
the
containers-595-url-when-connection-closed
branch
from
2074cbc to
4f1ab28
Compare
surayya-MS
approved these changes
Jan 16, 2025
...tainers/Microsoft.NET.Build.Containers/Exceptions/UnableToDownloadFromRepositoryException.cs
Outdated
Show resolved
Hide resolved
surayya-MS
reviewed
Jan 16, 2025
test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs
Outdated
Show resolved
Hide resolved
SimaTian
force-pushed
the
containers-595-url-when-connection-closed
branch
from
b066ff5 to
2238c89
Compare
SimaTian
force-pushed
the
containers-595-url-when-connection-closed
branch
from
af292b4 to
cc5e418
Compare
…ithub.com/dotnet/sdk into containers-595-url-when-connection-closed
SimaTian
force-pushed
the
containers-595-url-when-connection-closed
branch
from
8609778 to
a11bb4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the customers run into an issue with insufficient logging:
While I think the logging was since improved, this is my attempt to increase the granularity from a generic fail for download/upload repository interaction to a separate error for download and upload.