Move src/Installer components under src/Layout for better sharing and consolidation #47597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows better sharing between the layout components and eventually merging redist and redist-installer together.
ghost
added
ViktorHofer
changed the title
ViktorHofer
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR moves the Installer components under the Layout folder to consolidate shared code and updates affected paths accordingly.
- Moved Installer components under src/Layout
- Updated documentation link in workload-finalizer.md to reference the new location
Comments suppressed due to low confidence (1)
documentation/general/workloads/workload-finalizer.md:5
- [nitpick] The link text 'here' is ambiguous; consider using a more descriptive link text such as 'finalizer code documentation' to improve clarity.
The finalizer code is [here](/src/Layout/finalizer/README.md)
akoeplinger
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #45551
This will cause a merge conflict in #44611 & #47225 which I will then resolve post-merge.
Commit 1: Move src/Installer under src/Layout
This allows better sharing between the layout components
and eventually merging redist and redist-installer.
Commit 2: Update paths for the moved components