-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add container with SDK and scancode preinstalled #48622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0a0632b
4f222c5
55f800d
f18dd2f
bca6cbc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,6 +52,9 @@ extends: | |
name: NetCore1ESPool-Svc-Internal | ||
image: 1es-ubuntu-2204 | ||
os: linux | ||
containers: | ||
azurelinuxSourceBuildTestContainer: | ||
image: mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-net10.0-source-build-test-amd64 | ||
sdl: | ||
sourceAnalysisPool: | ||
name: NetCore1ESPool-Svc-Internal | ||
|
@@ -98,6 +101,7 @@ extends: | |
displayName: Get Matrix | ||
|
||
- job: LicenseScan | ||
container: azurelinuxSourceBuildTestContainer | ||
dependsOn: Setup | ||
timeoutInMinutes: 420 | ||
strategy: | ||
|
@@ -111,23 +115,14 @@ extends: | |
artifactName: $(Agent.JobName)_BuildLogs_Attempt$(System.JobAttempt) | ||
steps: | ||
|
||
- script: | | ||
source ./eng/common/tools.sh | ||
InitializeDotNetCli true | ||
displayName: Install .NET SDK | ||
workingDirectory: $(Build.SourcesDirectory) | ||
|
||
- task: PipAuthenticate@1 | ||
displayName: 'Pip Authenticate' | ||
inputs: | ||
artifactFeeds: public/dotnet-public-pypi | ||
onlyAddExtraIndex: false | ||
|
||
- script: $(sdkRoot)/eng/install-scancode.sh | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is anything still using this file, can it be removed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I searched for the keyword "scancode" in the source build repository and found that only the license scan test is using this toolkit. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does that confirm that it can be removed with this PR? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that script file should be deleted. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought I had removed this file in the previous update to the PR, but it looks like I missed it. I 've now included the update: f18dd2f |
||
displayName: Install Scancode | ||
|
||
- script: > | ||
$(Build.SourcesDirectory)/.dotnet/dotnet test | ||
dotnet test | ||
$(Build.SourcesDirectory)/test/Microsoft.DotNet.SourceBuild.Tests/Microsoft.DotNet.SourceBuild.Tests.csproj | ||
--filter "FullyQualifiedName=Microsoft.DotNet.SourceBuild.Tests.LicenseScanTests.ScanForLicenses" | ||
--logger:'trx;LogFileName=$(Agent.JobName)_LicenseScan.trx' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't needed anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Update: dotnet/dotnet#253