If a user expresses the intent to stifle the preview 'warning', make it happen on their behalf #49599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR lets SDK users suppress the .NET Core SDK preview warning by including its code (NETSDK1057) in the NoWarn property.
- Introduces a new
SuppressNETCoreSdkPreviewMessageproperty driven by$(NoWarn).Contains('NETSDK1057') - Modifies the preview-check target to skip warning emission when suppression is enabled
| @@ -329,6 +329,16 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
|
|
|||
| </Target> | |||
|
|
|||
| <PropertyGroup> | |||
There was a problem hiding this comment.
This change introduces new behavior to suppress the preview message based on NoWarn but lacks corresponding tests to verify this logic. Please add unit or integration tests covering scenarios where NETSDK1057 is and isn’t included in $(NoWarn).
Copilot generated this review using guidance from repository custom instructions.
…it happen on their behalf
baronfel
force-pushed
the
handle-nowarn-for-sdk-preview-message
branch
from
8e3d081 to
9b86ba2
Compare
dsplaisted
approved these changes
Jun 30, 2025
|
Tests added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/msbuild#12081.
We've trained users to reach for
$(NoWarn)as the solution to managing all kinds of warnings - but it doesn't work for Messages. Since that's a good chunk of work on the MSBuild side, let's do something in the near-term for SDK users specifically.