Test terminal logger with file-based apps #50187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds test coverage for the terminal logger functionality when running file-based applications to prevent regressions similar to the one fixed in a previous PR. The test ensures that the terminal logger can be properly enabled and disabled through the MSBUILDTERMINALLOGGER environment variable.
- Adds a new parameterized test method
TerminalLoggerthat verifies terminal logger behavior with file-based C# apps - Tests both enabled and disabled states of the terminal logger using combinatorial data
- Validates the presence or absence of ANSI escape sequences in output based on the logger setting
chsienki
approved these changes
Aug 12, 2025
MiYanni
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid regressions like the one fixed in #49969.