-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sample demonstrating how to connect session with Blazor and WebForms #542
Conversation
@twsouthwick I redid the branch because I screwed up the rebase yesterday. It should be all set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except let's break it out into its own sample so the blazor components in webforms one still works
* B: Block all requests from paths containing "/_blazor" | ||
* TLDR: We need to ensure that SystemWeb.Adapters is not used with Blazor SignalR | ||
*/ | ||
app.UseWhen( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a tracking issue for this? Not sure if this is the best way, but we should have an out of the box way to handle this I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I know of. I mentioned the deadlock in my previous PR and ended up with this workaround to get my project (and this sample) working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good for the sample for now. could you create an issue to track this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app.MapBlazorHub(); | ||
app.MapBlazorPages("/_Host"); | ||
app.MapForwarder("/{**catch-all}", app.Configuration["ProxyTo"]!).WithOrder(int.MaxValue); | ||
app.MapRazorComponents<App>() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks the existing sample that is to show using blazor components in webforms. It seems like this sample you have should be a separate one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! I did not see that initially. it's fine as-is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for rebasing and the work here.
PR Title
Updated sample demonstrating how to connect session with Blazor and WebForms using a Blazor Web App
PR Description
Updated sample demonstrating how to connect session with Blazor and WebForms using a Blazor Web App
Addresses #382