Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darken TabControl in dark mode #12471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

willibrandon
Copy link
Contributor

@willibrandon willibrandon commented Nov 13, 2024

Fixes #11953

Proposed changes

  • Style TabControl and make it dark in Dark mode.

Customer Impact

  • Fixes an issue with TabControl not being dark enough in Dark mode.

Regression?

  • No

Risk

  • I believe the risk is low.

Screenshots

Before

TabControlDarkModeBefore

After

TabControlDarkModeAfter

Test methodology

  • Manually tested via scratch project.

Test environment(s)

.NET SDK:
 Version:           9.0.100
 Commit:            59db016f11
 Workload version:  9.0.100-manifests.c6f19616
 MSBuild version:   17.12.7+5b8665660

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.26120
 OS Platform: Windows
 RID:         win-x64
 Base Path:   C:\Program Files\dotnet\sdk\9.0.100\
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.71412%. Comparing base (237d294) to head (ff8cd62).

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12471         +/-   ##
===================================================
- Coverage   75.71876%   75.71412%   -0.00465%     
===================================================
  Files           3152        3152                 
  Lines         635709      635715          +6     
  Branches       46970       46971          +1     
===================================================
- Hits          481351      481326         -25     
- Misses        150927      150944         +17     
- Partials        3431        3445         +14     
Flag Coverage Δ
Debug 75.71412% <0.00000%> (-0.00465%) ⬇️
integration 18.26307% <0.00000%> (-0.00746%) ⬇️
production 49.27047% <0.00000%> (-0.01020%) ⬇️
test 97.05059% <ø> (+0.00028%) ⬆️
unit 46.25161% <0.00000%> (+0.01839%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@willibrandon
Copy link
Contributor Author

This is not an area I specialize in and could use some guidance. My plan is to help tackle the remaining dark mode help wanted issues if this approach is acceptable. I have done my best to glean from the work that has already been done and have been experimenting with the dark mode themes that I see in .msstyles.

Am I correct that in an ideal world these controls would not require this additional styling?

@xPaw
Copy link
Contributor

xPaw commented Nov 14, 2024

These are also tackled in #11985

@willibrandon
Copy link
Contributor Author

These are also tackled in #11985

To me it looks like that PR could be the start of a new API proposal. In this PR, my goal is to fix the issue without introducing any new public APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dark Mode] TabControl is not in dark mode after enabled SystemColorMode.Dark
2 participants