Override SelectInternal to add UIA_AutomationFocusChangedEventId in PropertyGridView.GridViewTextBox #12479
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ropertyGridView.GridViewTextBox
|
There have extra "item selected" is announced for BackColor/ForeColor/Cursor property with Narrator and the issue cannot reproduce with NVDA tools 
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12479 +/- ##
===================================================
+ Coverage 75.73242% 75.74259% +0.01017%
===================================================
Files 3153 3153
Lines 635807 635814 +7
Branches 46975 46976 +1
===================================================
+ Hits 481512 481582 +70
+ Misses 150870 150802 -68
- Partials 3425 3430 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12421
Proposed changes
SelectInternalin PropertyGridView.GridViewTextBox to addRaiseAutomationEvent(UIA_EVENT_ID.UIA_AutomationFocusChangedEventId)Customer Impact
Regression?
Risk
Screenshots
Before
When switching the items by using up/down keyboard arrow that without expand the dropdown list panel, Narrator can not announced the property item entirety.
After
When switching the items by using up/down keyboard arrow that without expand the dropdown list panel, Narrator announced the property item entirety.
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow