[release/9.0][Accessibility] Fix keyboard navigation and screen reader experience in dropdown type editors in property grid #12605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xBase.cs (dotnet#12479) * Add UIA_AutomationFocusChangedEventId in SelectInternal function of PropertyGridView.GridViewTextBox * Add a check that when the selected text is (0, 0), let the AI rectangle refocus the current text box * Rename the variables of function SelectInternal
…UpAndDown (dotnet#12508) * Unhook the mouse down hook at the end of PropertyGridView.ProcessEnumUpAndDown * Removing ? from code line "EditTextBox?.SelectAll();"
…ties.All)] on PropertyGridView.cs (dotnet#12356)
…switch property values on edit textBox (dotnet#12431) * Fix editor text box focus issue when switching value property grid view * Override function SelectInternal in file PropertyGridView.GridViewTextBox.cs * Removing fullRefresh condition from function Refresh
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/9.0 #12605 +/- ##
=====================================================
- Coverage 74.83047% 74.82951% -0.00097%
=====================================================
Files 3022 3022
Lines 630258 630258
Branches 46794 46794
=====================================================
- Hits 471625 471619 -6
+ Misses 155253 155249 -4
- Partials 3380 3390 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
Tanya-Solyanik
changed the title
Tanya-Solyanik
changed the title
Tanya-Solyanik
added
the
📬 waiting-for-testing
lonitra
added
the
🚫 * NO-MERGE *
|
This will need to wait until February servicing is open for merge. |
|
This has been tested by testing team, it works well with all main accessibility tools. |
LeafShi1
removed
the
📬 waiting-for-testing
LeafShi1
added
the
waiting-review
Tanya-Solyanik
approved these changes
Jan 7, 2025
Tanya-Solyanik
added
Servicing-consider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12508, #12431, #12356 and #12479 to release/9.0
Fixes #12607
NET10 Bugs: #12434, #12421, #12440, #12031
Bug Description
There are four issues that occur when using the up/down keys to switch property values in the property page.
When navigating to "Auto Size" dropdown using the up/down arrow keys, it is getting auto selected without hitting ENTER
After using Tab to switch property values, then using the up/down keys to switch items in the drop-down box expanded by F4 will cause the drop-down box to collapse directly
[Accessibility] When using up/down to toggle property value on edit text box, The Accessibility rectangle focuses on the entire property row instead of the original edit text box
[Accessibility] Narrator cannot announce items correctly when switching the items by using up/down keyboard arrow that without expand the dropdown list panel
Customer Impact
PropertyGrid drop down type editor does not support conventional keyboard navigation. Usually, selection is committed when the ENTER key is pressed. However, in this case value is committed on the Down arrow press. Then the drop down list is expanded, the screen reader user might want to navigate through all values in the drop down using the arrows, on each arrow key press the new item should be presented (and announced) in the selection text box, however, the drop down is closed on the first arrow key. According to the accessibility SMEs, this is a major problem - the keyboard users are losing their work by committing a wrong value. Screen reader user don't get correct feedback when navigating through the drop down list.
Regression?
No, Keyboard navigation had been designed incorrectly from the .NET Framework.
Yes for issue #12421
Testing done
Risk
low.
Microsoft Reviewers: Open in CodeFlow